Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6901)

Unified Diff: chrome/browser/app_controller_mac_browsertest.mm

Issue 2475913003: Enabling kUseConsolidatedStartupFlow by default on trunk. (Closed)
Patch Set: Rebase-updated Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac_browsertest.mm
diff --git a/chrome/browser/app_controller_mac_browsertest.mm b/chrome/browser/app_controller_mac_browsertest.mm
index 52ced35b3bf71e57ea06ff5b41e58e875d55a644..1cd7d02865412075323492e482d00084681b51db 100644
--- a/chrome/browser/app_controller_mac_browsertest.mm
+++ b/chrome/browser/app_controller_mac_browsertest.mm
@@ -44,6 +44,7 @@
#include "components/bookmarks/test/bookmark_test_helpers.h"
#include "components/prefs/pref_service.h"
#include "components/signin/core/common/profile_management_switches.h"
+#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_navigation_observer.h"
@@ -393,7 +394,8 @@ class AppControllerOpenShortcutBrowserTest : public InProcessBrowserTest {
IN_PROC_BROWSER_TEST_F(AppControllerOpenShortcutBrowserTest,
OpenShortcutOnStartup) {
- EXPECT_EQ(1, browser()->tab_strip_model()->count());
+ // The two tabs expected are the Welcome page and the desired URL.
+ EXPECT_EQ(2, browser()->tab_strip_model()->count());
EXPECT_EQ(g_open_shortcut_url,
browser()->tab_strip_model()->GetActiveWebContents()
->GetLastCommittedURL());
@@ -420,6 +422,15 @@ IN_PROC_BROWSER_TEST_F(AppControllerReplaceNTPBrowserTest,
// Ensure that there is exactly 1 tab showing, and the tab is the NTP.
GURL ntp(chrome::kChromeUINewTabURL);
EXPECT_EQ(1, browser()->tab_strip_model()->count());
+ browser()->tab_strip_model()->GetActiveWebContents()->GetController().LoadURL(
+ GURL(chrome::kChromeUINewTabURL), content::Referrer(),
+ ui::PageTransition::PAGE_TRANSITION_LINK, std::string());
+
+ // Wait for one navigation on the active web contents.
+ content::TestNavigationObserver ntp_navigation_observer(
+ browser()->tab_strip_model()->GetActiveWebContents());
+ ntp_navigation_observer.Wait();
+
EXPECT_EQ(ntp,
browser()
->tab_strip_model()
@@ -429,11 +440,10 @@ IN_PROC_BROWSER_TEST_F(AppControllerReplaceNTPBrowserTest,
GURL simple(embedded_test_server()->GetURL("/simple.html"));
SendAppleEventToOpenUrlToAppController(simple);
- // Wait for one navigation on the active web contents.
EXPECT_EQ(1, browser()->tab_strip_model()->count());
- content::TestNavigationObserver obs(
- browser()->tab_strip_model()->GetActiveWebContents(), 1);
- obs.Wait();
+ content::TestNavigationObserver event_navigation_observer(
+ browser()->tab_strip_model()->GetActiveWebContents());
+ event_navigation_observer.Wait();
EXPECT_EQ(simple,
browser()
« no previous file with comments | « no previous file | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698