Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2475773003:
Fix some flaky event tests in ImeTest (Closed)
DescriptionFix some flaky event tests in ImeTest
Some Ime tests are flaky because the event order is incorrect. Since
selectionchange event is queued, it's delayed and often comes after other
event, e.g. keyup event. As a workaround, we can ignore the order of
selectionchange event.
BUG=650691, 628964
Committed: https://crrev.com/4d1708cdd327cc4f038addd36153e0b86082bf2d
Cr-Commit-Position: refs/heads/master@{#429813}
Patch Set 1 #Patch Set 2 #
Total comments: 4
Patch Set 3 : Address aelias@'s review #
Messages
Total messages: 20 (14 generated)
The CQ bit was checked by yabinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix some flaky event tests in ImeTest Some Ime tests are flaky because the event order is incorrectly. Since selectionchange event is queued, it's delayed and often comes after other event, e.g. keyup event. As a workaround, we can ignore the event order. BUG=628964,628964 ========== to ========== Fix some flaky event tests in ImeTest Some Ime tests are flaky because the event order is incorrect. Since selectionchange event is queued, it's delayed and often comes after other event, e.g. keyup event. As a workaround, we can ignore the event order. BUG=650691,628964 ==========
Description was changed from ========== Fix some flaky event tests in ImeTest Some Ime tests are flaky because the event order is incorrect. Since selectionchange event is queued, it's delayed and often comes after other event, e.g. keyup event. As a workaround, we can ignore the event order. BUG=650691,628964 ========== to ========== Fix some flaky event tests in ImeTest Some Ime tests are flaky because the event order is incorrect. Since selectionchange event is queued, it's delayed and often comes after other event, e.g. keyup event. As a workaround, we can ignore the order of selectionchange event. BUG=650691,628964 ==========
yabinh@chromium.org changed reviewers: + aelias@chromium.org, changwan@chromium.org
PTAL~
The CQ bit was checked by yabinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2475773003/diff/20001/content/public/android/... File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/2475773003/diff/20001/content/public/android/... content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:1359: @RetryOnFailure Just to confirm: is the only known reason this is needed because of the screen-off problem? https://codereview.chromium.org/2475773003/diff/20001/content/test/data/andro... File content/test/data/android/input/input_forms.html (right): https://codereview.chromium.org/2475773003/diff/20001/content/test/data/andro... content/test/data/android/input/input_forms.html:60: // selectionchange event is queued, so it's delayed and comes after other events incorrectly. I'd rephrase this "so it races with the other events"
The CQ bit was checked by yabinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2475773003/diff/20001/content/public/android/... File content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java (right): https://codereview.chromium.org/2475773003/diff/20001/content/public/android/... content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:1359: @RetryOnFailure On 2016/11/04 03:40:07, aelias wrote: > Just to confirm: is the only known reason this is needed because of the > screen-off problem? Yes. I'll remove it once the screen-off problem is fixed. https://codereview.chromium.org/2475773003/diff/20001/content/test/data/andro... File content/test/data/android/input/input_forms.html (right): https://codereview.chromium.org/2475773003/diff/20001/content/test/data/andro... content/test/data/android/input/input_forms.html:60: // selectionchange event is queued, so it's delayed and comes after other events incorrectly. On 2016/11/04 03:40:07, aelias wrote: > I'd rephrase this "so it races with the other events" Done.
The CQ bit was unchecked by yabinh@chromium.org
The CQ bit was checked by yabinh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org Link to the patchset: https://codereview.chromium.org/2475773003/#ps40001 (title: "Address aelias@'s review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix some flaky event tests in ImeTest Some Ime tests are flaky because the event order is incorrect. Since selectionchange event is queued, it's delayed and often comes after other event, e.g. keyup event. As a workaround, we can ignore the order of selectionchange event. BUG=650691,628964 ========== to ========== Fix some flaky event tests in ImeTest Some Ime tests are flaky because the event order is incorrect. Since selectionchange event is queued, it's delayed and often comes after other event, e.g. keyup event. As a workaround, we can ignore the order of selectionchange event. BUG=650691,628964 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix some flaky event tests in ImeTest Some Ime tests are flaky because the event order is incorrect. Since selectionchange event is queued, it's delayed and often comes after other event, e.g. keyup event. As a workaround, we can ignore the order of selectionchange event. BUG=650691,628964 ========== to ========== Fix some flaky event tests in ImeTest Some Ime tests are flaky because the event order is incorrect. Since selectionchange event is queued, it's delayed and often comes after other event, e.g. keyup event. As a workaround, we can ignore the order of selectionchange event. BUG=650691,628964 Committed: https://crrev.com/4d1708cdd327cc4f038addd36153e0b86082bf2d Cr-Commit-Position: refs/heads/master@{#429813} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4d1708cdd327cc4f038addd36153e0b86082bf2d Cr-Commit-Position: refs/heads/master@{#429813} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
