Issue 247573009: Uninline JSON{Array,Object}Base methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247573009: Uninline JSON{Array,Object}Base methods (Closed)

Created:
6 years, 8 months ago by fs

Modified:
6 years, 8 months ago

Reviewers:
pfeldman

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Uninline JSON{Array,Object}Base methods Most of these are sizable enough to not want to inline too eagerly. Move their definitions from the header-file to the cpp-file while dropping the 'inline' keyword. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172482

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -85 lines)			Patch
	M	Source/platform/JSONValues.h	View		1 chunk	+0 lines, -85 lines	0 comments	Download
	M	Source/platform/JSONValues.cpp	View		2 chunks	+84 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Pavel, you appeared to be a decent choice for reviewing this (since the primary [only?] ...

6 years, 8 months ago (2014-04-24 08:19:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/247573009/1

6 years, 8 months ago (2014-04-24 10:51:51 UTC) #4

Message was sent while issue was closed.

Change committed as 172482

Expand Messages | Collapse Messages