Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 247573004: Always mark cross-origin as true for regular media urls (Closed)

Created:
6 years, 8 months ago by qinmin
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Always mark cross-origin as true for regular media urls We cannot guarantee that urls will not be redirected when android mediaplayer requests video streams. Always treat media urls as cross-origin for now. BUG=334204 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266396

Patch Set 1 #

Total comments: 2

Patch Set 2 : adding crbug #

Patch Set 3 : fix MediaInfoLoaderTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/renderer/media/android/media_info_loader.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
qinmin
PTAL
6 years, 8 months ago (2014-04-22 21:38:14 UTC) #1
scherkus (not reviewing)
lgtm w/ nit https://codereview.chromium.org/247573004/diff/1/content/renderer/media/android/media_info_loader.cc File content/renderer/media/android/media_info_loader.cc (right): https://codereview.chromium.org/247573004/diff/1/content/renderer/media/android/media_info_loader.cc#newcode35 content/renderer/media/android/media_info_loader.cc:35: // a single origin. Set this ...
6 years, 8 months ago (2014-04-24 17:18:32 UTC) #2
qinmin
https://codereview.chromium.org/247573004/diff/1/content/renderer/media/android/media_info_loader.cc File content/renderer/media/android/media_info_loader.cc (right): https://codereview.chromium.org/247573004/diff/1/content/renderer/media/android/media_info_loader.cc#newcode35 content/renderer/media/android/media_info_loader.cc:35: // a single origin. Set this back to true ...
6 years, 8 months ago (2014-04-24 17:40:50 UTC) #3
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 8 months ago (2014-04-24 17:40:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/247573004/20001
6 years, 8 months ago (2014-04-24 21:54:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 23:09:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 8 months ago (2014-04-24 23:09:33 UTC) #7
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 8 months ago (2014-04-25 00:21:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/247573004/20001
6 years, 8 months ago (2014-04-25 00:21:39 UTC) #9
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 8 months ago (2014-04-25 23:57:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/247573004/40001
6 years, 8 months ago (2014-04-25 23:58:11 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 08:01:59 UTC) #12
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 8 months ago (2014-04-26 08:02:00 UTC) #13
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 8 months ago (2014-04-26 19:04:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/247573004/40001
6 years, 8 months ago (2014-04-26 19:06:02 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-04-27 00:17:06 UTC) #16
Message was sent while issue was closed. 
Change committed as 266396

Powered by Google App Engine
This is Rietveld 408576698