Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 247573003: Fix build: Windows has dibs on IGNORE (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
Reviewers:
bungeman-skia, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix build: Windows has dibs on IGNORE Also, make sure to undef macros after we're done with them. BUG=skia: NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/record/SkRecordOpts.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M src/record/SkRecords.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein
6 years, 8 months ago (2014-04-22 17:53:25 UTC) #1
bungeman-skia
lgtm, you macro using maniac.
6 years, 8 months ago (2014-04-22 17:56:42 UTC) #2
mtklein
On 2014/04/22 17:56:42, bungeman1 wrote: > lgtm, you macro using maniac. Yeah, actually, I even ...
6 years, 8 months ago (2014-04-22 18:00:57 UTC) #3
mtklein
lgtm
6 years, 8 months ago (2014-04-22 18:01:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/247573003/1
6 years, 8 months ago (2014-04-22 18:01:12 UTC) #5
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 8 months ago (2014-04-22 18:32:17 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-22 18:32:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/247573003/1
6 years, 8 months ago (2014-04-22 18:32:41 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 18:33:00 UTC) #9
Message was sent while issue was closed.
Change committed as 14305

Powered by Google App Engine
This is Rietveld 408576698