Do not reset NavigationHandle when navigating same-page

chrome/browser/ssl/chrome_security_state_model_client_unittest.cc

Index: chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc b/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
index 711c17cfcf9155fadbad38030854769bb2c2b182..ddb460d6937edddb616dd317115e045674ac7f0c 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
@@ -273,6 +273,8 @@ class ChromeSecurityStateModelClientHistogramTest
 
   void navigate_to_http() { NavigateAndCommit(GURL("http://example.test")); }
 
+  void navigate_to_http_2() { NavigateAndCommit(GURL("http://example2.test")); }

[estark, 2016/11/04 14:53:59]

nit: could you rename this to navigate_to_different_http_page() please?

[clamy, 2016/11/04 15:47:25]

Done.

+
  private:
   ChromeSecurityStateModelClient* client_;
   DISALLOW_COPY_AND_ASSIGN(ChromeSecurityStateModelClientHistogramTest);
@@ -296,7 +298,7 @@ TEST_F(ChromeSecurityStateModelClientHistogramTest,
   histograms.ExpectUniqueSample(kHTTPBadHistogram, true, 1);
 
   // Navigate to a new page and ensure a sample is recorded.
-  navigate_to_http();
+  navigate_to_http_2();
   histograms.ExpectUniqueSample(kHTTPBadHistogram, true, 1);
   signal_password();
   histograms.ExpectUniqueSample(kHTTPBadHistogram, true, 2);
@@ -319,7 +321,7 @@ TEST_F(ChromeSecurityStateModelClientHistogramTest,
   histograms.ExpectUniqueSample(kHTTPBadHistogram, false, 1);
 
   // Navigate to a new page and ensure a sample is recorded.
-  navigate_to_http();
+  navigate_to_http_2();
   histograms.ExpectUniqueSample(kHTTPBadHistogram, false, 1);
   signal_password();
   histograms.ExpectUniqueSample(kHTTPBadHistogram, false, 2);