Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2475693002: Do not reset NavigationHandle when navigating same-page (Closed)
Patch Set: Rebase + removed DCHECK Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 538b119bb2bb6134070b9306054d695c70b8756d..110a19e65431f158be4bdbb0267940eb214dcf8f 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -50,6 +50,7 @@ class GURL;
struct AccessibilityHostMsg_EventParams;
struct AccessibilityHostMsg_FindInPageResultParams;
struct AccessibilityHostMsg_LocationChangeParams;
+struct FrameHostMsg_DidCommitProvisionalLoad_Params;
struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
struct FrameHostMsg_OpenURL_Params;
struct FrameMsg_TextTrackSettings_Params;
@@ -809,6 +810,11 @@ class CONTENT_EXPORT RenderFrameHostImpl
void OnRendererConnect(const service_manager::ServiceInfo& local_info,
const service_manager::ServiceInfo& remote_info);
+ // Returns ownership of the NavigationHandle associated with a navigation that
+ // just committed.
+ std::unique_ptr<NavigationHandleImpl> TakeNavigationHandleForCommit(
+ const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
+
// For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
// refcount that calls Shutdown when it reaches zero. This allows each
// RenderFrameHostManager to just care about RenderFrameHosts, while ensuring

Powered by Google App Engine
This is Rietveld 408576698