Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client_unittest.cc

Issue 2475693002: Do not reset NavigationHandle when navigating same-page (Closed)
Patch Set: Rebase + removed DCHECK Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc b/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
index 711c17cfcf9155fadbad38030854769bb2c2b182..0bf0fdc44c62d18233ef9819bf0e0330151a6b3a 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client_unittest.cc
@@ -273,6 +273,10 @@ class ChromeSecurityStateModelClientHistogramTest
void navigate_to_http() { NavigateAndCommit(GURL("http://example.test")); }
+ void navigate_to_different_http_page() {
+ NavigateAndCommit(GURL("http://example2.test"));
+ }
+
private:
ChromeSecurityStateModelClient* client_;
DISALLOW_COPY_AND_ASSIGN(ChromeSecurityStateModelClientHistogramTest);
@@ -296,7 +300,7 @@ TEST_F(ChromeSecurityStateModelClientHistogramTest,
histograms.ExpectUniqueSample(kHTTPBadHistogram, true, 1);
// Navigate to a new page and ensure a sample is recorded.
- navigate_to_http();
+ navigate_to_different_http_page();
histograms.ExpectUniqueSample(kHTTPBadHistogram, true, 1);
signal_password();
histograms.ExpectUniqueSample(kHTTPBadHistogram, true, 2);
@@ -319,7 +323,7 @@ TEST_F(ChromeSecurityStateModelClientHistogramTest,
histograms.ExpectUniqueSample(kHTTPBadHistogram, false, 1);
// Navigate to a new page and ensure a sample is recorded.
- navigate_to_http();
+ navigate_to_different_http_page();
histograms.ExpectUniqueSample(kHTTPBadHistogram, false, 1);
signal_password();
histograms.ExpectUniqueSample(kHTTPBadHistogram, false, 2);

Powered by Google App Engine
This is Rietveld 408576698