Do not reset NavigationHandle when navigating same-page

third_party/WebKit/Source/core/loader/FrameLoader.cpp

Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index f220e5cf8cbe9fc28bc989ffb60ee9c092637017..f3e4d758ee61bced8082cce35416cc49f741d522 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -776,7 +776,7 @@ void FrameLoader::updateForSameDocumentNavigation(
   // Generate start and stop notifications only when loader is completed so that
   // we don't fire them for fragment redirection that happens in window.onload
   // handler. See https://bugs.webkit.org/show_bug.cgi?id=31838
-  if (m_frame->document()->loadEventFinished())
+  if (m_frame->document()->loadEventFinished() && !m_provisionalDocumentLoader)

[Charlie Reis, 2016/11/03 22:02:22]

I'm curious-- how is this related to the rest of the CL?  I think it might be
worth mentioning something in the comment above.

[clamy, 2016/11/04 14:18:21]

Without it, we still delete the NavigationHandle of the ongoing navigation when
doing the same-page navigation because we will send a DidStopLoading IPC.
Sending the IPC is wrong if we're in the middle of another navigation (ie we
have a provisional document loader).

[Charlie Reis, 2016/11/04 17:30:53]

Acknowledged.

     client()->didStartLoading(NavigationWithinSameDocument);
 
   HistoryCommitType historyCommitType = loadTypeToCommitType(type);
@@ -799,7 +799,7 @@ void FrameLoader::updateForSameDocumentNavigation(
   client()->dispatchDidNavigateWithinPage(
       m_currentItem.get(), historyCommitType, !!initiatingDocument);
   client()->dispatchDidReceiveTitle(m_frame->document()->title());
-  if (m_frame->document()->loadEventFinished())
+  if (m_frame->document()->loadEventFinished() && !m_provisionalDocumentLoader)
     client()->didStopLoading();
 }