Do not reset NavigationHandle when navigating same-page

content/browser/frame_host/render_frame_host_impl.h

Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index f0d8d06376d69286e96bfca5db50aa2f39ee9ff3..068032c5c17fc98498c2bb9a8355751599a18cd2 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -50,6 +50,7 @@ class GURL;
 struct AccessibilityHostMsg_EventParams;
 struct AccessibilityHostMsg_FindInPageResultParams;
 struct AccessibilityHostMsg_LocationChangeParams;
+struct FrameHostMsg_DidCommitProvisionalLoad_Params;
 struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
 struct FrameHostMsg_OpenURL_Params;
 struct FrameMsg_TextTrackSettings_Params;
@@ -820,6 +821,11 @@ class CONTENT_EXPORT RenderFrameHostImpl
   void OnRendererConnect(const service_manager::ServiceInfo& local_info,
                          const service_manager::ServiceInfo& remote_info);
 
+  // Returns the NavigationHandle associated with a navigation that just
+  // committed.
+  std::unique_ptr<NavigationHandleImpl> FindNavigationHandleForCommit(

[Charlie Reis, 2016/11/03 22:02:22]

This sounds like an accessor, and it doesn't make it clear that this method
resets the RFH's own handle in most cases.  Can you clarify?

[clamy, 2016/11/04 14:18:21]

I've updated the comment and renamed the method. If you have better naming
suggestions, please let me know.

[Charlie Reis, 2016/11/04 17:30:53]

I think that works-- thanks.

+      const FrameHostMsg_DidCommitProvisionalLoad_Params& params);
+
   // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
   // refcount that calls Shutdown when it reaches zero.  This allows each
   // RenderFrameHostManager to just care about RenderFrameHosts, while ensuring