content/browser/frame_host/navigator_impl.h - Issue 2475693002: Do not reset NavigationHandle when navigating same-page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.h

Issue 2475693002: Do not reset NavigationHandle when navigating same-page (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigator_impl.h

diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h

index a2bf25ccdc10a8fe889d58383fa5bb500470968c..0bbd28648f2d22aa6af3ac275a88ccb04eb41a0d 100644

--- a/content/browser/frame_host/navigator_impl.h

+++ b/content/browser/frame_host/navigator_impl.h

@@ -56,7 +56,8 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {

bool was_ignored_by_handler) override;

void DidNavigate(

RenderFrameHostImpl* render_frame_host,

- const FrameHostMsg_DidCommitProvisionalLoad_Params& params) override;

+ const FrameHostMsg_DidCommitProvisionalLoad_Params& params,

+ std::unique_ptr<NavigationHandleImpl> navigation_handle) override;

bool NavigateToPendingEntry(FrameTreeNode* frame_tree_node,

const FrameNavigationEntry& frame_entry,

ReloadType reload_type,