Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: content/browser/frame_host/interstitial_page_navigator_impl.cc

Issue 2475693002: Do not reset NavigationHandle when navigating same-page (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/interstitial_page_navigator_impl.cc
diff --git a/content/browser/frame_host/interstitial_page_navigator_impl.cc b/content/browser/frame_host/interstitial_page_navigator_impl.cc
index a19deefa127366eb78f867e56bc8c4c4d7fd73b0..9aec514379798833b3c0a0af4c15126fba5297eb 100644
--- a/content/browser/frame_host/interstitial_page_navigator_impl.cc
+++ b/content/browser/frame_host/interstitial_page_navigator_impl.cc
@@ -45,7 +45,8 @@ void InterstitialPageNavigatorImpl::DidStartProvisionalLoad(
void InterstitialPageNavigatorImpl::DidNavigate(
RenderFrameHostImpl* render_frame_host,
- const FrameHostMsg_DidCommitProvisionalLoad_Params& input_params) {
+ const FrameHostMsg_DidCommitProvisionalLoad_Params& input_params,
+ std::unique_ptr<NavigationHandleImpl> navigation_handle) {
if (navigation_handle_) {
navigation_handle_->DidCommitNavigation(input_params, false,
Charlie Reis 2016/11/03 22:02:22 This looks incorrect now. We should assume that s
clamy 2016/11/04 14:18:21 I'm now checking if the navigation that just commi
render_frame_host);

Powered by Google App Engine
This is Rietveld 408576698