testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter - Issue 2475693002: Do not reset NavigationHandle when navigating same-page

Side by Side Diff: testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter

Issue 2475693002: Do not reset NavigationHandle when navigating same-page (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 -NavigationControllerBrowserTest.FrameNavigationEntry_RecreatedInjectedSrcdocSub frame	1 -NavigationControllerBrowserTest.FrameNavigationEntry_RecreatedInjectedSrcdocSub frame

2 -RenderFrameHostManagerTest.RestoreSubframeFileAccessForHistoryNavigation	2 -RenderFrameHostManagerTest.RestoreSubframeFileAccessForHistoryNavigation

3 -RequestDataResourceDispatcherHostBrowserTest.*	3 -RequestDataResourceDispatcherHostBrowserTest.*

4	4

5 # NavigationPreload dosn't work well with PlzNavigate yet. https://crbug.com/649 558	5 # NavigationPreload dosn't work well with PlzNavigate yet. https://crbug.com/649 558

6 -ServiceWorkerBrowserTest/ServiceWorkerNavigationPreloadTest.*	6 -ServiceWorkerBrowserTest/ServiceWorkerNavigationPreloadTest.*

7	7

	8 # Browser-initiated fragment navigations are handled improperly

	9 -NavigationControllerBrowserTest.SamePageBrowserInitiated
	Charlie Reis 2016/11/04 17:30:53 Why is this disabled for PlzNavigate? (I'm genera Why is this disabled for PlzNavigate? (I'm generally ok with fixing for that mode later, but it would be helpful to understand why.) clamy 2016/11/07 14:10:51 Because we don't classify browser-initiated same-p Show quoted text On 2016/11/04 17:30:53, Charlie Reis (OOO til 11-11) wrote: > Why is this disabled for PlzNavigate? (I'm generally ok with fixing for that > mode later, but it would be helpful to understand why.) Because we don't classify browser-initiated same-page navigations as same-page navigations in PlzNavigate, and we send them to the network. So the NavigationHandle has IsSamePage set to false. Charlie Reis 2016/11/08 06:38:53 Ah, thanks. Is there a bug on file to fix that? Show quoted text On 2016/11/07 14:10:51, clamy wrote: > On 2016/11/04 17:30:53, Charlie Reis (OOO til 11-11) wrote: > > Why is this disabled for PlzNavigate? (I'm generally ok with fixing for that > > mode later, but it would be helpful to understand why.) > > Because we don't classify browser-initiated same-page navigations as same-page > navigations in PlzNavigate, and we send them to the network. So the > NavigationHandle has IsSamePage set to false. Ah, thanks. Is there a bug on file to fix that? clamy 2016/11/09 18:05:52 I've filed https://bugs.chromium.org/p/chromium/is Show quoted text On 2016/11/08 06:38:53, Charlie Reis (OOO til 11-11) wrote: > On 2016/11/07 14:10:51, clamy wrote: > > On 2016/11/04 17:30:53, Charlie Reis (OOO til 11-11) wrote: > > > Why is this disabled for PlzNavigate? (I'm generally ok with fixing for > that > > > mode later, but it would be helpful to understand why.) > > > > Because we don't classify browser-initiated same-page navigations as same-page > > navigations in PlzNavigate, and we send them to the network. So the > > NavigationHandle has IsSamePage set to false. > > Ah, thanks. Is there a bug on file to fix that? I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=663777.
	10

8 # Fail in Debug	11 # Fail in Debug

9 -DevToolsProtocolTest.ControlNavigationsMainFrame	12 -DevToolsProtocolTest.ControlNavigationsMainFrame

10 -IsolatedDevToolsProtocolTest.ControlNavigationsChildFrames	13 -IsolatedDevToolsProtocolTest.ControlNavigationsChildFrames

11 -NavigationControllerBrowserTest.RaceCrossOriginNavigationAndSamePageHistoryNavi gation	14 -NavigationControllerBrowserTest.RaceCrossOriginNavigationAndSamePageHistoryNavi gation

OLD	NEW