Do not reset NavigationHandle when navigating same-page

content/browser/frame_host/navigator.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/time/time.h"
 #include "content/browser/frame_host/navigator_delegate.h"
@@ skipping 54 matching lines @@
       const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {};
 
   // The RenderFrameHostImpl has failed to load the document.
   virtual void DidFailLoadWithError(
       RenderFrameHostImpl* render_frame_host,
       const GURL& url,
       int error_code,
       const base::string16& error_description,
       bool was_ignored_by_handler) {}
 
   // The RenderFrameHostImpl has committed a navigation.

[Charlie Reis, 2016/11/03 22:02:22]

nit: Mention something about how we shouldn't assume that |navigation_handle|
matches RFH's current NavigationHandle, and that DidNavigate is responsible for
resetting |navigation_handle| at the end of this method (and shouldn't keep it
alive).

[clamy, 2016/11/04 14:18:21]

Done.

   virtual void DidNavigate(
       RenderFrameHostImpl* render_frame_host,
-      const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {}
+      const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
+      std::unique_ptr<NavigationHandleImpl> navigation_handle) {}
 
   // Called by the NavigationController to cause the Navigator to navigate
   // to the current pending entry. The NavigationController should be called
   // back with RendererDidNavigate on success or DiscardPendingEntry on failure.
   // The callbacks can be inside of this function, or at some future time.
   //
   // If this method returns false, then the navigation is discarded (equivalent
   // to calling DiscardPendingEntry on the NavigationController).
   //
   // TODO(nasko): Remove this method from the interface, since Navigator and
@@ skipping 106 matching lines @@
   virtual void DiscardPendingEntryIfNeeded(NavigationHandleImpl* handle) {}
 
  protected:
   friend class base::RefCounted<Navigator>;
   virtual ~Navigator() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_