[DevTools] Roll third_party/inspector_protocol to 3c6f5ff8ab6653b47cf226233d488701a527d761.

[DevTools] Roll third_party/inspector_protocol to 3c6f5ff8ab6653b47cf226233d488701a527d761.

Roll includes:
- Add missing virtual destructor to backend callbacks.
- Support config.protocol.options which defines which part of protocol definition should be generated.

Additional changes:
- Removed handlers = renderer and async information from protocol.
- Added handlers/async information to inspector_protocol_config.json.
- Added handlers/async information to generator in content/browser.

BUG=635953
Committed: https://crrev.com/262e483fc7532d8b7e24c7ef40c53ad4dee94f9a
Cr-Commit-Position: refs/heads/master@{#430387}

[dgozman, 2016-11-04 22:34:59]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org, kozyatinskiy@chromium.org

[dgozman, 2016-11-04 22:35:00]

Could you please take a look?

[kozy, 2016-11-04 23:13:57]

lgtm

[caseq, 2016-11-05 01:32:25]

https://codereview.chromium.org/2475663004/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/devtools_protocol_handler_generator.py
(right):

https://codereview.chromium.org/2475663004/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:660:
async_commands_list = [
let's move this out of the code into some config and perhaps put it next to the
protocol.

https://codereview.chromium.org/2475663004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
(right):

https://codereview.chromium.org/2475663004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/inspector_protocol_config.json:35: {
"command": "+Page.getResourceContent", "async": true },
I find this config format rather difficult to read. Let's structure this after
protocol.json itself -- make it a list of domains that would have lists of
included/excluded symbols within, along with "async" list if needed.

{
   "domain": "Page",
   "exclude": [ "screencastFrame", ... ]
   "async": [ "getResourcecont", ... ]
}

[dgozman, 2016-11-07 17:27:21]

PTAL

https://codereview.chromium.org/2475663004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
(right):

https://codereview.chromium.org/2475663004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/inspector_protocol_config.json:35: {
"command": "+Page.getResourceContent", "async": true },
On 2016/11/05 01:32:25, caseq wrote:
> I find this config format rather difficult to read. Let's structure this after
> protocol.json itself -- make it a list of domains that would have lists of
> included/excluded symbols within, along with "async" list if needed.
> 
> {
>    "domain": "Page",
>    "exclude": [ "screencastFrame", ... ]
>    "async": [ "getResourcecont", ... ]
> }

Done.

[dgozman, 2016-11-07 17:27:22]

PTAL

https://codereview.chromium.org/2475663004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
(right):

https://codereview.chromium.org/2475663004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/inspector_protocol_config.json:35: {
"command": "+Page.getResourceContent", "async": true },
On 2016/11/05 01:32:25, caseq wrote:
> I find this config format rather difficult to read. Let's structure this after
> protocol.json itself -- make it a list of domains that would have lists of
> included/excluded symbols within, along with "async" list if needed.
> 
> {
>    "domain": "Page",
>    "exclude": [ "screencastFrame", ... ]
>    "async": [ "getResourcecont", ... ]
> }

Done.

[caseq, 2016-11-07 18:19:39]

lgtm

[dgozman, 2016-11-07 19:12:03]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 19:12:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-11-07 19:49:18]

Description was changed from

==========
[DevTools] Remove handlers = renderer and async information from protocol.

This information is now provided separately to each generator.

BUG=635953
==========

to

==========
[DevTools] Roll third_party/inspector_protocol to
3c6f5ff8ab6653b47cf226233d488701a527d761.

Roll includes:
- Add missing virtual destructor to backend callbacks.
- Support config.protocol.options which defines which part of protocol
definition should be generated.

Additional changes:
- Removed handlers = renderer and async information from protocol.
- Added handlers/async information to inspector_protocol_config.json.
- Added handlers/async information to generator in content/browser.

BUG=635953
==========

[dgozman, 2016-11-07 19:53:30]

Description was changed from

==========
[DevTools] Roll third_party/inspector_protocol to
3c6f5ff8ab6653b47cf226233d488701a527d761.

Roll includes:
- Add missing virtual destructor to backend callbacks.
- Support config.protocol.options which defines which part of protocol
definition should be generated.

Additional changes:
- Removed handlers = renderer and async information from protocol.
- Added handlers/async information to inspector_protocol_config.json.
- Added handlers/async information to generator in content/browser.

BUG=635953
==========

to

==========
[DevTools] Roll third_party/inspector_protocol to
3c6f5ff8ab6653b47cf226233d488701a527d761.

Roll includes:
- Add missing virtual destructor to backend callbacks.
- Support config.protocol.options which defines which part of protocol
definition should be generated.

Additional changes:
- Removed handlers = renderer and async information from protocol.
- Added handlers/async information to inspector_protocol_config.json.
- Added handlers/async information to generator in content/browser.

BUG=635953
==========

[dgozman, 2016-11-07 19:54:24]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-11-07 19:54:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2475663004/#ps40001
(title: "roll")

[commit-bot: I haz the power, 2016-11-07 19:54:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 21:53:54]

Description was changed from

==========
[DevTools] Roll third_party/inspector_protocol to
3c6f5ff8ab6653b47cf226233d488701a527d761.

Roll includes:
- Add missing virtual destructor to backend callbacks.
- Support config.protocol.options which defines which part of protocol
definition should be generated.

Additional changes:
- Removed handlers = renderer and async information from protocol.
- Added handlers/async information to inspector_protocol_config.json.
- Added handlers/async information to generator in content/browser.

BUG=635953
==========

to

==========
[DevTools] Roll third_party/inspector_protocol to
3c6f5ff8ab6653b47cf226233d488701a527d761.

Roll includes:
- Add missing virtual destructor to backend callbacks.
- Support config.protocol.options which defines which part of protocol
definition should be generated.

Additional changes:
- Removed handlers = renderer and async information from protocol.
- Added handlers/async information to inspector_protocol_config.json.
- Added handlers/async information to generator in content/browser.

BUG=635953
==========

[commit-bot: I haz the power, 2016-11-07 21:53:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-07 22:21:57]

Description was changed from

==========
[DevTools] Roll third_party/inspector_protocol to
3c6f5ff8ab6653b47cf226233d488701a527d761.

Roll includes:
- Add missing virtual destructor to backend callbacks.
- Support config.protocol.options which defines which part of protocol
definition should be generated.

Additional changes:
- Removed handlers = renderer and async information from protocol.
- Added handlers/async information to inspector_protocol_config.json.
- Added handlers/async information to generator in content/browser.

BUG=635953
==========

to

==========
[DevTools] Roll third_party/inspector_protocol to
3c6f5ff8ab6653b47cf226233d488701a527d761.

Roll includes:
- Add missing virtual destructor to backend callbacks.
- Support config.protocol.options which defines which part of protocol
definition should be generated.

Additional changes:
- Removed handlers = renderer and async information from protocol.
- Added handlers/async information to inspector_protocol_config.json.
- Added handlers/async information to generator in content/browser.

BUG=635953

Committed: https://crrev.com/262e483fc7532d8b7e24c7ef40c53ad4dee94f9a
Cr-Commit-Position: refs/heads/master@{#430387}
==========

[commit-bot: I haz the power, 2016-11-07 22:21:59]

Patchset 3 (id:??) landed as
https://crrev.com/262e483fc7532d8b7e24c7ef40c53ad4dee94f9a
Cr-Commit-Position: refs/heads/master@{#430387}