Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2475663003: Rename navigationPreload of FetchEvent to preloadResponse (Closed)

Created:
4 years, 1 month ago by horo
Modified:
4 years, 1 month ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, haraken, kinuko+serviceworker, horo+watch_chromium.org, blink-reviews, darin-cc_chromium.org, kinuko+watch, tzik, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename navigationPreload of FetchEvent to preloadResponse We had implemented it as "FetchEvent.avigationPreload". But in the spec discussion, it seems to be defined as "FetchEvent.preloadResponse". https://github.com/w3c/ServiceWorker/pull/983#pullrequestreview-6410334 BUG=649558 Committed: https://crrev.com/95d26e23d47ff912eefe1d1caa7dc67552b3ffae Cr-Commit-Position: refs/heads/master@{#429815}

Patch Set 1 #

Patch Set 2 : update global-interface-listing-service-worker-expected.txt #

Messages

Total messages: 16 (11 generated)
horo
falken@ Please review this.
4 years, 1 month ago (2016-11-04 05:04:08 UTC) #8
falken
lgtm
4 years, 1 month ago (2016-11-04 05:18:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475663003/20001
4 years, 1 month ago (2016-11-04 06:38:11 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 06:47:46 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 06:49:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95d26e23d47ff912eefe1d1caa7dc67552b3ffae
Cr-Commit-Position: refs/heads/master@{#429815}

Powered by Google App Engine
This is Rietveld 408576698