Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 2475643004: Monitor the intersection of video and viewport. (Closed)
Patch Set: Consolidate two ElementVisibilityObserver in AUtoplayUmaHelper. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
index c927eeb9db8409a3900dd725e0749b70eb442480..b8ca4c16c67bed67699e0381ef6f82a4fa5a8fcd 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
@@ -534,7 +534,7 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,
EnumerationHistogram& showControlsHistogram() const;
- void onVisibilityChangedForAutoplay(bool isVisible);
+ void onVideoViewportRatioChanged(bool isVisible);
UnthrottledThreadTimer<HTMLMediaElement> m_loadTimer;
UnthrottledThreadTimer<HTMLMediaElement> m_progressEventTimer;
@@ -716,11 +716,11 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,
Member<AutoplayExperimentHelper::Client> m_autoplayHelperClient;
Member<AutoplayExperimentHelper> m_autoplayHelper;
Member<AutoplayUmaHelper> m_autoplayUmaHelper;
+ bool m_autoplayWhenVisible = false;
miu 2016/11/05 02:47:47 naming nit: m_shouldAutoplayWhenVisible
miu 2016/11/05 02:47:47 Is the boolean necessary? (See comment in .cpp fil
xjz 2016/11/09 02:24:28 I keeps this boolean to save a bunch of checks eve
xjz 2016/11/09 02:24:28 Done.
WebRemotePlaybackClient* m_remotePlaybackClient;
- // class AutoplayVisibilityObserver;
- Member<ElementVisibilityObserver> m_autoplayVisibilityObserver;
+ Member<ElementVisibilityObserver> m_videoViewportRatioObserver;
static URLRegistry* s_mediaStreamRegistry;
};

Powered by Google App Engine
This is Rietveld 408576698