Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

Issue 2475643004: Monitor the intersection of video and viewport. (Closed)
Patch Set: Consolidate two ElementVisibilityObserver in AUtoplayUmaHelper. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/ElementVisibilityObserver.h" 5 #include "core/dom/ElementVisibilityObserver.h"
6 6
7 #include "core/dom/Element.h" 7 #include "core/dom/Element.h"
8 #include "core/dom/IntersectionObserverEntry.h" 8 #include "core/dom/IntersectionObserverEntry.h"
9 #include "core/frame/LocalFrame.h" 9 #include "core/frame/LocalFrame.h"
10 #include "wtf/Functional.h" 10 #include "wtf/Functional.h"
(...skipping 11 matching lines...) Expand all
22 } // anonymous namespace 22 } // anonymous namespace
23 23
24 ElementVisibilityObserver::ElementVisibilityObserver( 24 ElementVisibilityObserver::ElementVisibilityObserver(
25 Element* element, 25 Element* element,
26 std::unique_ptr<VisibilityCallback> callback) 26 std::unique_ptr<VisibilityCallback> callback)
27 : m_element(element), m_callback(std::move(callback)) {} 27 : m_element(element), m_callback(std::move(callback)) {}
28 28
29 ElementVisibilityObserver::~ElementVisibilityObserver() = default; 29 ElementVisibilityObserver::~ElementVisibilityObserver() = default;
30 30
31 void ElementVisibilityObserver::start() { 31 void ElementVisibilityObserver::start() {
32 start(Vector<float>({std::numeric_limits<float>::min()}));
33 }
34
35 void ElementVisibilityObserver::start(const Vector<float>& thresholds) {
32 ExecutionContext* context = m_element->getExecutionContext(); 36 ExecutionContext* context = m_element->getExecutionContext();
33 DCHECK(context->isDocument()); 37 DCHECK(context->isDocument());
34 Document& document = toDocument(*context); 38 Document& document = toDocument(*context);
35 39
36 // TODO(zqzhang): IntersectionObserver does not work for RemoteFrame. 40 // TODO(zqzhang): IntersectionObserver does not work for RemoteFrame.
37 // Remove this early return when it's fixed. See https://crbug.com/615156 41 // Remove this early return when it's fixed. See https://crbug.com/615156
38 if (isInRemoteFrame(document)) { 42 if (isInRemoteFrame(document)) {
39 m_element.release(); 43 m_element.release();
40 return; 44 return;
41 } 45 }
42 46
43 DCHECK(!m_intersectionObserver); 47 DCHECK(!m_intersectionObserver);
44 m_intersectionObserver = IntersectionObserver::create( 48 m_intersectionObserver = IntersectionObserver::create(
45 Vector<Length>(), Vector<float>({std::numeric_limits<float>::min()}), 49 Vector<Length>(), thresholds, &document,
46 &document, WTF::bind(&ElementVisibilityObserver::onVisibilityChanged, 50 WTF::bind(&ElementVisibilityObserver::onVisibilityChanged,
47 wrapWeakPersistent(this))); 51 wrapWeakPersistent(this)));
48 DCHECK(m_intersectionObserver); 52 DCHECK(m_intersectionObserver);
49 m_intersectionObserver->setInitialState( 53 m_intersectionObserver->setInitialState(
50 IntersectionObserver::InitialState::kAuto); 54 IntersectionObserver::InitialState::kAuto);
51 m_intersectionObserver->observe(m_element.release()); 55 m_intersectionObserver->observe(m_element.release());
52 } 56 }
53 57
54 void ElementVisibilityObserver::stop() { 58 void ElementVisibilityObserver::stop() {
55 // TODO(zqzhang): IntersectionObserver does not work for RemoteFrame, 59 // TODO(zqzhang): IntersectionObserver does not work for RemoteFrame,
56 // so |m_intersectionObserver| may be null at this point after start(). 60 // so |m_intersectionObserver| may be null at this point after start().
57 // Replace this early return with DCHECK when this has been fixed. See 61 // Replace this early return with DCHECK when this has been fixed. See
58 // https://crbug.com/615156 62 // https://crbug.com/615156
59 if (!m_intersectionObserver) 63 if (!m_intersectionObserver)
60 return; 64 return;
61 65
62 m_intersectionObserver->disconnect(); 66 m_intersectionObserver->disconnect();
63 m_intersectionObserver = nullptr; 67 m_intersectionObserver = nullptr;
64 } 68 }
65 69
66 void ElementVisibilityObserver::deliverObservationsForTesting() { 70 void ElementVisibilityObserver::deliverObservationsForTesting() {
67 m_intersectionObserver->deliver(); 71 m_intersectionObserver->deliver();
68 } 72 }
69 73
70 DEFINE_TRACE(ElementVisibilityObserver) { 74 DEFINE_TRACE(ElementVisibilityObserver) {
71 visitor->trace(m_element); 75 visitor->trace(m_element);
72 visitor->trace(m_intersectionObserver); 76 visitor->trace(m_intersectionObserver);
73 } 77 }
74 78
75 void ElementVisibilityObserver::onVisibilityChanged( 79 void ElementVisibilityObserver::onVisibilityChanged(
76 const HeapVector<Member<IntersectionObserverEntry>>& entries) { 80 const HeapVector<Member<IntersectionObserverEntry>>& entries) {
77 bool isVisible = entries.last()->intersectionRatio() > 0.f; 81 m_ratio = entries.last()->intersectionRatio();
82 bool isVisible = m_ratio > 0.f;
78 (*m_callback.get())(isVisible); 83 (*m_callback.get())(isVisible);
79 } 84 }
80 85
81 } // namespace blink 86 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698