Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2475643003: [ios] Use square brackets syntax for nulling out toJSON property. (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
Reviewers:
baxley
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Use square brackets syntax for nulling out toJSON property. Closure reports an error for the old code: ../../ios/web/web_state/js/resources/common.js:40: ERROR - assignment to property toJSON of __gCrWeb.common.JSONSafeObject.prototype found : null required: function (this:Object, string=): * __gCrWeb.common.JSONSafeObject.prototype.toJSON = null; ^ BUG=None Committed: https://crrev.com/02176404cf7da8bc6bdc4650285419d5de0e7f5a Cr-Commit-Position: refs/heads/master@{#429702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/web/web_state/js/resources/common.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-11-03 16:49:05 UTC) #4
baxley
lgtm
4 years, 1 month ago (2016-11-03 19:51:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475643003/1
4 years, 1 month ago (2016-11-03 21:34:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 21:40:21 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 21:44:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02176404cf7da8bc6bdc4650285419d5de0e7f5a
Cr-Commit-Position: refs/heads/master@{#429702}

Powered by Google App Engine
This is Rietveld 408576698