|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by aleksandar.stojiljkovic Modified:
4 years, 1 month ago CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWorkaround for undeclared identifier V4L2_PIX_FMT_INVZ.
Realsense SR300 driver installation patches the kernel currently.
Until the format is officially introduced to kernel, enable using it and
resolve build error on kernel > 4.6.
BUG=661877
Committed: https://crrev.com/957ba284b09867e3d6c7054a5e2fcc29c37d3722
Cr-Commit-Position: refs/heads/master@{#429810}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
aleksandar.stojiljkovic@intel.com changed reviewers: + mcasas@chromium.org
mcasas@, PTAL. Realsense SR300 driver installation patches the kernel currently [1]. Until the format is officially introduced to kernel enable using it without build error on kernel > 4.6. [1] https://github.com/IntelRealSense/librealsense/blob/cf6f1ca4b7687b04007c0c8a1...
On 2016/11/03 13:44:39, aleksandar.stojiljkovic wrote: > mcasas@, PTAL. > > Realsense SR300 driver installation patches the kernel currently [1]. > Until the format is officially introduced to kernel enable using it without > build error on kernel > 4.6. > [1] > https://github.com/IntelRealSense/librealsense/blob/cf6f1ca4b7687b04007c0c8a1... non-owner l g t m.
Description was changed from ========== Workaround for undeclared identifier V4L2_PIX_FMT_INVZ. The format is not yet introduced to kernel. Until it is, enable using it. BUG=661877 ========== to ========== Workaround for undeclared identifier V4L2_PIX_FMT_INVZ. Build problem doesn't happen on any bots, but happens when building on kernel >= 4.6. The format is not yet introduced to kernel. Until it is, enable using it. BUG=661877 ==========
aleksandar.stojiljkovic@intel.com changed reviewers: + perkj@chromium.org
+perkj_chrome, PTAL. Thanks. Increasing the number of reviewers in case someone is away today - good to have this resolved soon.
Description was changed from ========== Workaround for undeclared identifier V4L2_PIX_FMT_INVZ. Build problem doesn't happen on any bots, but happens when building on kernel >= 4.6. The format is not yet introduced to kernel. Until it is, enable using it. BUG=661877 ========== to ========== Workaround for undeclared identifier V4L2_PIX_FMT_INVZ. Realsense SR300 driver installation patches the kernel currently. Until the format is officially introduced to kernel, enable using it and resolve build error on kernel > 4.6. BUG=661877 ==========
On 2016/11/03 21:11:08, aleksandar.stojiljkovic wrote: > +perkj_chrome, PTAL. > Thanks. > Increasing the number of reviewers in case someone is away today - good to have > this resolved soon. oops, missed this review. lgtm
The CQ bit was checked by aleksandar.stojiljkovic@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/03 21:44:12, mcasas wrote: > On 2016/11/03 21:11:08, aleksandar.stojiljkovic wrote: > > +perkj_chrome, PTAL. > > Thanks. > > Increasing the number of reviewers in case someone is away today - good to > have > > this resolved soon. > > oops, missed this review. lgtm Thanks mcasas@. Let me cover the status of upstream work on the bug page.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by aleksandar.stojiljkovic@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Workaround for undeclared identifier V4L2_PIX_FMT_INVZ. Realsense SR300 driver installation patches the kernel currently. Until the format is officially introduced to kernel, enable using it and resolve build error on kernel > 4.6. BUG=661877 ========== to ========== Workaround for undeclared identifier V4L2_PIX_FMT_INVZ. Realsense SR300 driver installation patches the kernel currently. Until the format is officially introduced to kernel, enable using it and resolve build error on kernel > 4.6. BUG=661877 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Workaround for undeclared identifier V4L2_PIX_FMT_INVZ. Realsense SR300 driver installation patches the kernel currently. Until the format is officially introduced to kernel, enable using it and resolve build error on kernel > 4.6. BUG=661877 ========== to ========== Workaround for undeclared identifier V4L2_PIX_FMT_INVZ. Realsense SR300 driver installation patches the kernel currently. Until the format is officially introduced to kernel, enable using it and resolve build error on kernel > 4.6. BUG=661877 Committed: https://crrev.com/957ba284b09867e3d6c7054a5e2fcc29c37d3722 Cr-Commit-Position: refs/heads/master@{#429810} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/957ba284b09867e3d6c7054a5e2fcc29c37d3722 Cr-Commit-Position: refs/heads/master@{#429810} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
