Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 2475603002: Inline FundamentalValue into base::Value (Closed)

Created:
3 years, 5 months ago by brettw
Modified:
3 years, 1 month ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, jdoerrie
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline FundamentalValue into base::Value

Patch Set 1 #

Patch Set 2 : Merge #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -94 lines) Patch
M base/values.h View 1 3 chunks +28 lines, -17 lines 1 comment Download
M base/values.cc View 5 chunks +91 lines, -77 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
brettw
Merge
3 years, 4 months ago (2016-11-19 17:30:29 UTC) #5
vabr (Chromium)
Hi Brett! The failing BluetoothTypeConvertorTest, which created a FundamentalValue from another one by mistake, discovered ...
3 years, 4 months ago (2016-12-07 14:31:11 UTC) #11
brettw
Thanks, I'll close this review in preference to your copy.
3 years, 4 months ago (2016-12-08 22:15:01 UTC) #12
brettw
Thanks, I'll close this review in preference to your copy.
3 years, 4 months ago (2016-12-08 22:15:01 UTC) #13
vabr (Chromium)
3 years, 1 month ago (2017-02-12 18:49:59 UTC) #14
On 2016/12/08 22:15:01, brettw (plz ping after 24h) wrote:
> Thanks, I'll close this review in preference to your copy.

Actually closing this to get it out of the Rietveld dashboard.
The CL which replaced this one was eventually jdoerrie's
https://codereview.chromium.org/2645073002/.

Powered by Google App Engine
This is Rietveld 408576698