base/values.cc - Issue 2475583002: Adds option for JSON reader to allow invalid utf characters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.cc

Issue 2475583002: Adds option for JSON reader to allow invalid utf characters (Closed)

Patch Set: replace Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values.cc

diff --git a/base/values.cc b/base/values.cc

index f00a03f8d3097896b7176052368cfdbb7fbfb8dd..407f9c5edcc55c28dc84436941f55f74a18fd3d2 100644

--- a/base/values.cc

+++ b/base/values.cc

@@ -253,7 +253,8 @@ bool FundamentalValue::Equals(const Value* other) const {

StringValue::StringValue(StringPiece in_value)

: Value(TYPE_STRING), value_(in_value.as_string()) {

- DCHECK(IsStringUTF8(in_value));

+ // NOTE: no DCHECK that |in_value| is valid utf-8. We explicitly allow invalid

+ // utf-8.

}

StringValue::StringValue(const string16& in_value)