Adds option for JSON reader to allow invalid utf characters

base/values.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/values.h"
 
 #include <string.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 235 matching lines @@
     default:
       NOTREACHED();
       return false;
   }
 }
 
 ///////////////////// StringValue ////////////////////
 
 StringValue::StringValue(StringPiece in_value)
     : Value(TYPE_STRING), value_(in_value.as_string()) {
-  DCHECK(IsStringUTF8(in_value));
+  // NOTE: no DCHECK that |in_value| is valid utf-8. We explicitly allow invalid

[sky, 2016/11/03 19:14:14]

My rationale here for removing the DCHECK is that UTF16ToUTF8 below basically
continues on with invalid input.

+  // utf-8.
 }
 
 StringValue::StringValue(const string16& in_value)
     : Value(TYPE_STRING),
       value_(UTF16ToUTF8(in_value)) {
 }
 
 StringValue::~StringValue() {
 }
 
@@ skipping 900 matching lines @@
 ValueDeserializer::~ValueDeserializer() {
 }
 
 std::ostream& operator<<(std::ostream& out, const Value& value) {
   std::string json;
   JSONWriter::WriteWithOptions(value, JSONWriter::OPTIONS_PRETTY_PRINT, &json);
   return out << json;
 }
 
 }  // namespace base