Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2475543002: arc: Fix missing notification on extended desktop (Closed)

Created:
4 years, 1 month ago by xiyuan
Modified:
4 years, 1 month ago
Reviewers:
yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Fix missing notification on extended desktop The notification is missing because old ArcCustomNotificationView is removed from widget first before ViewHierarchyChanged, which causes the bail out logic be skipped. The CL updates the bail out condition so that the bail out logic runs for the case and did not detach notification surface from the new ArcCustomNotificationView. BUG=661801 Committed: https://crrev.com/24290805c28dbf3da5220464d68befac854244ad Cr-Commit-Position: refs/heads/master@{#429599}

Patch Set 1 #

Patch Set 2 : more explicit for bail-out condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
xiyuan
4 years, 1 month ago (2016-11-02 22:47:58 UTC) #3
yoshiki
lgtm. Thanks!
4 years, 1 month ago (2016-11-02 22:51:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475543002/20001
4 years, 1 month ago (2016-11-03 15:42:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 15:50:35 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 16:11:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24290805c28dbf3da5220464d68befac854244ad
Cr-Commit-Position: refs/heads/master@{#429599}

Powered by Google App Engine
This is Rietveld 408576698