src/heap/heap.cc - Issue 2475503004: [heap] Allow repeatedly setting EmbedderHeapTracer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 2475503004: [heap] Allow repeatedly setting EmbedderHeapTracer (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 104175ddacbd172724fc30bcb676be8375b2bd06..064e3f36919ff51045b630367d463a9dfc9f5a86 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -5552,8 +5552,7 @@ void Heap::NotifyDeserializationComplete() {

}

void Heap::SetEmbedderHeapTracer(EmbedderHeapTracer* tracer) {

- DCHECK_NOT_NULL(tracer);

- CHECK_NULL(embedder_heap_tracer_);

+ DCHECK_EQ(gc_state_, HeapState::NOT_IN_GC);

embedder_heap_tracer_ = tracer;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »