Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2475503004: [heap] Allow repeatedly setting EmbedderHeapTracer (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Allow repeatedly setting EmbedderHeapTracer Allow swapping the tracer if not in a GC. BUG=chromium:468240 TBR=ulan@chromium.org NOTRY=true Committed: https://crrev.com/0eeee7cee944900606bc32beff3fcd8b55cd00d5 Cr-Commit-Position: refs/heads/master@{#40719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475503004/1
4 years, 1 month ago (2016-11-03 11:02:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 11:04:25 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:20:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0eeee7cee944900606bc32beff3fcd8b55cd00d5
Cr-Commit-Position: refs/heads/master@{#40719}

Powered by Google App Engine
This is Rietveld 408576698