Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2475503002: Fix inconsistency between included headers and calls (Closed)

Created:
4 years, 1 month ago by cfroussios
Modified:
4 years, 1 month ago
Reviewers:
Tom Anderson
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix inconsistency between included headers and calls. The call to OSCryptMockerLinux was guarded by a different precompiler condition than the inclusion of its header. BUG=661693 Committed: https://crrev.com/6be9170d75ff0ce95a3cd163fe0a0ab693ae8fc6 Cr-Commit-Position: refs/heads/master@{#429377}

Patch Set 1 #

Patch Set 2 : remove garbage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/os_crypt/os_crypt_mocker.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
cfroussios
Hi! Thanks for bring bug to my attention. Can you review this simple change? Thanks!
4 years, 1 month ago (2016-11-02 18:55:14 UTC) #7
Tom Anderson
On 2016/11/02 18:55:14, cfroussios wrote: > Hi! Thanks for bring bug to my attention. Can ...
4 years, 1 month ago (2016-11-02 18:57:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475503002/20001
4 years, 1 month ago (2016-11-02 19:54:42 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 20:04:18 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6be9170d75ff0ce95a3cd163fe0a0ab693ae8fc6
Cr-Commit-Position: refs/heads/master@{#429377}

Powered by Google App Engine
This is Rietveld 408576698