Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2475483003: jingle: inline gypi file into BUILD.gn file (Closed)

Created:
4 years, 1 month ago by tfarina
Modified:
4 years, 1 month ago
CC:
chromium-reviews, Nicolas Zea
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

jingle: inline gypi file into BUILD.gn file Remove jingle.gypi as it is not necessary to share the list of source files between GYP and GN anymore. BUG=None R=sergeyu@chromium.org,dpranke@chromium.org Committed: https://crrev.com/e35da66e69e7208161d73fd05a7472360f1a8ecc Cr-Commit-Position: refs/heads/master@{#429691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -31 lines) Patch
M jingle/BUILD.gn View 1 chunk +17 lines, -6 lines 0 comments Download
D jingle/jingle.gypi View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
tfarina
4 years, 1 month ago (2016-11-03 01:14:35 UTC) #3
Sergey Ulanov
lgtm
4 years, 1 month ago (2016-11-03 17:17:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475483003/1
4 years, 1 month ago (2016-11-03 17:52:40 UTC) #9
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-03 19:00:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 20:50:52 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 20:53:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e35da66e69e7208161d73fd05a7472360f1a8ecc
Cr-Commit-Position: refs/heads/master@{#429691}

Powered by Google App Engine
This is Rietveld 408576698