Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: content/renderer/media/webmediaplayer_ms.cc

Issue 2475473002: Implement one-shot audio focus inside MediaSession (Closed)
Patch Set: nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webmediaplayer_ms.cc
diff --git a/content/renderer/media/webmediaplayer_ms.cc b/content/renderer/media/webmediaplayer_ms.cc
index c8b28aaff1e5f06549949902a3d67ae2d1a340fc..dc8d4ba7584459ce84806de45345163a157bb3bc 100644
--- a/content/renderer/media/webmediaplayer_ms.cc
+++ b/content/renderer/media/webmediaplayer_ms.cc
@@ -181,11 +181,11 @@ void WebMediaPlayerMS::play() {
audio_renderer_->Play();
if (delegate_) {
- // TODO(perkj, magjed): We use Uncontrollable type here to avoid creating an
- // interactive media session on Android. See http://crbug.com/596516 for
- // more details.
+ // TODO(perkj, magjed): We use OneShot focus type here so that it takes
+ // audio focus once it starts, and then will not respond to further audio
+ // focus changes. See http://crbug.com/596516 for more details.
delegate_->DidPlay(delegate_id_, hasVideo(), hasAudio(), false,
- media::MediaContentType::Persistent);
+ media::MediaContentType::OneShot);
}
paused_ = false;

Powered by Google App Engine
This is Rietveld 408576698