content/browser/media/session/pepper_playback_observer.cc - Issue 2475473002: Implement one-shot audio focus inside MediaSession

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/session/pepper_playback_observer.cc

Issue 2475473002: Implement one-shot audio focus inside MediaSession (Closed)

Patch Set: fixed a case where removing the last one-shot player Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/media/session/pepper_playback_observer.cc

diff --git a/content/browser/media/session/pepper_playback_observer.cc b/content/browser/media/session/pepper_playback_observer.cc

index 440157b04f2f5685e4a0d9a1d70c1798c3d6988b..593d3d727788cbe6e11d9ef6fddc44479fed0e47 100644

--- a/content/browser/media/session/pepper_playback_observer.cc

+++ b/content/browser/media/session/pepper_playback_observer.cc

@@ -65,7 +65,7 @@ void PepperPlaybackObserver::PepperStartsPlayback(int32_t pp_instance) {

MediaSessionImpl::Get(contents_)->AddPlayer(

players_map_[pp_instance].get(), PepperPlayerDelegate::kPlayerId,

ShouldDuckFlash() ? media::MediaContentType::Pepper

- : media::MediaContentType::Persistent);

+ : media::MediaContentType::OneShot);

}

void PepperPlaybackObserver::PepperStopsPlayback(int32_t pp_instance) {