src/api-natives.cc - Issue 2475433008: Set global proxy internal field count based on the global object template.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api-natives.cc

Issue 2475433008: Set global proxy internal field count based on the global object template. (Closed)

Patch Set: oops Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api-natives.cc

diff --git a/src/api-natives.cc b/src/api-natives.cc

index 5a78003140010b8b4dbb5ea5c74462371039300e..b0212c063a0bb0f31ae96e517be50e5c6f5765d8 100644

--- a/src/api-natives.cc

+++ b/src/api-natives.cc

@@ -640,8 +640,7 @@ Handle<JSFunction> ApiNatives::CreateApiFunction(

break;

case GlobalProxyType:

type = JS_GLOBAL_PROXY_TYPE;

- instance_size += JSGlobalProxy::kSize;

- DCHECK_EQ(instance_size, JSGlobalProxy::kSizeWithInternalFields);

+ instance_size += JSGlobalProxy::kHeaderSize;

break;

default:

UNREACHABLE();

« no previous file with comments | « src/api.cc ('k') | src/bootstrapper.cc » ('j') | src/objects.h » ('J')