Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/objects-inl.h

Issue 2475433008: Set global proxy internal field count based on the global object template. (Closed)
Patch Set: oops Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 2060 matching lines...) Expand 10 before | Expand all | Expand 10 after
2071 // falling into the generic switch. This speeds up the internal 2071 // falling into the generic switch. This speeds up the internal
2072 // field operations considerably on average. 2072 // field operations considerably on average.
2073 if (type == JS_OBJECT_TYPE) return JSObject::kHeaderSize; 2073 if (type == JS_OBJECT_TYPE) return JSObject::kHeaderSize;
2074 switch (type) { 2074 switch (type) {
2075 case JS_API_OBJECT_TYPE: 2075 case JS_API_OBJECT_TYPE:
2076 case JS_SPECIAL_API_OBJECT_TYPE: 2076 case JS_SPECIAL_API_OBJECT_TYPE:
2077 return JSObject::kHeaderSize; 2077 return JSObject::kHeaderSize;
2078 case JS_GENERATOR_OBJECT_TYPE: 2078 case JS_GENERATOR_OBJECT_TYPE:
2079 return JSGeneratorObject::kSize; 2079 return JSGeneratorObject::kSize;
2080 case JS_GLOBAL_PROXY_TYPE: 2080 case JS_GLOBAL_PROXY_TYPE:
2081 return JSGlobalProxy::kSize; 2081 return JSGlobalProxy::kHeaderSize;
2082 case JS_GLOBAL_OBJECT_TYPE: 2082 case JS_GLOBAL_OBJECT_TYPE:
2083 return JSGlobalObject::kSize; 2083 return JSGlobalObject::kSize;
2084 case JS_BOUND_FUNCTION_TYPE: 2084 case JS_BOUND_FUNCTION_TYPE:
2085 return JSBoundFunction::kSize; 2085 return JSBoundFunction::kSize;
2086 case JS_FUNCTION_TYPE: 2086 case JS_FUNCTION_TYPE:
2087 return JSFunction::kSize; 2087 return JSFunction::kSize;
2088 case JS_VALUE_TYPE: 2088 case JS_VALUE_TYPE:
2089 return JSValue::kSize; 2089 return JSValue::kSize;
2090 case JS_DATE_TYPE: 2090 case JS_DATE_TYPE:
2091 return JSDate::kSize; 2091 return JSDate::kSize;
(...skipping 6339 matching lines...) Expand 10 before | Expand all | Expand 10 after
8431 #undef WRITE_INT64_FIELD 8431 #undef WRITE_INT64_FIELD
8432 #undef READ_BYTE_FIELD 8432 #undef READ_BYTE_FIELD
8433 #undef WRITE_BYTE_FIELD 8433 #undef WRITE_BYTE_FIELD
8434 #undef NOBARRIER_READ_BYTE_FIELD 8434 #undef NOBARRIER_READ_BYTE_FIELD
8435 #undef NOBARRIER_WRITE_BYTE_FIELD 8435 #undef NOBARRIER_WRITE_BYTE_FIELD
8436 8436
8437 } // namespace internal 8437 } // namespace internal
8438 } // namespace v8 8438 } // namespace v8
8439 8439
8440 #endif // V8_OBJECTS_INL_H_ 8440 #endif // V8_OBJECTS_INL_H_
OLDNEW
« src/objects.h ('K') | « src/objects.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698