Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2475433006:
Add "Cast..." menu item to macOS menu bar (Closed)
|
Created:
4 years, 1 month ago by takumif Modified:
4 years, 1 month ago Reviewers:
Robert Sesek CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd "Cast..." menu item to macOS menu bar
The "Cast..." item is added in the Files section, right under "Print...".
Its functionality is equivalent to the Cast option in the hotdog menu: it opens
a Media Router dialog, is disabled when we already have a dialog open, and is
not shown when Media Router is disabled.
BUG=601207
Committed: https://crrev.com/996eb9a468745d8f4af72cf7da57876c51886ae2
Cr-Commit-Position: refs/heads/master@{#431914}
Patch Set 1 #
Messages
Total messages: 21 (14 generated)
Description was changed from ========== . BUG= ========== to ========== Add "Cast..." menu item to macOS menu bar The "Cast..." item is added in the Files section, right under "Print...". Its functionality is equivalent to the Cast option in the hotdog menu: it opens a Media Router dialog, is disabled when we already have a dialog open, and is not shown when Media Router is disabled. BUG=601207 ==========
Patchset #1 (id:1) has been deleted
takumif@chromium.org changed reviewers: + erikchen@chromium.org
takumif@chromium.org changed reviewers: - erikchen@chromium.org
Patchset #1 (id:20001) has been deleted
takumif@chromium.org changed reviewers: + rsesek@chromium.org
Please take a look, thank you!
LGTM
But please wrap your CL description to ~80 columns, to make it easier to read in `git log`.
Description was changed from ========== Add "Cast..." menu item to macOS menu bar The "Cast..." item is added in the Files section, right under "Print...". Its functionality is equivalent to the Cast option in the hotdog menu: it opens a Media Router dialog, is disabled when we already have a dialog open, and is not shown when Media Router is disabled. BUG=601207 ========== to ========== Add "Cast..." menu item to macOS menu bar The "Cast..." item is added in the Files section, right under "Print...". Its functionality is equivalent to the Cast option in the hotdog menu: it opens a Media Router dialog, is disabled when we already have a dialog open, and is not shown when Media Router is disabled. BUG=601207 ==========
The CQ bit was checked by takumif@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/14 19:01:04, Robert Sesek wrote: > But please wrap your CL description to ~80 columns, to make it easier to read in > `git log`. Done. Thanks for reviewing!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by takumif@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add "Cast..." menu item to macOS menu bar The "Cast..." item is added in the Files section, right under "Print...". Its functionality is equivalent to the Cast option in the hotdog menu: it opens a Media Router dialog, is disabled when we already have a dialog open, and is not shown when Media Router is disabled. BUG=601207 ========== to ========== Add "Cast..." menu item to macOS menu bar The "Cast..." item is added in the Files section, right under "Print...". Its functionality is equivalent to the Cast option in the hotdog menu: it opens a Media Router dialog, is disabled when we already have a dialog open, and is not shown when Media Router is disabled. BUG=601207 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add "Cast..." menu item to macOS menu bar The "Cast..." item is added in the Files section, right under "Print...". Its functionality is equivalent to the Cast option in the hotdog menu: it opens a Media Router dialog, is disabled when we already have a dialog open, and is not shown when Media Router is disabled. BUG=601207 ========== to ========== Add "Cast..." menu item to macOS menu bar The "Cast..." item is added in the Files section, right under "Print...". Its functionality is equivalent to the Cast option in the hotdog menu: it opens a Media Router dialog, is disabled when we already have a dialog open, and is not shown when Media Router is disabled. BUG=601207 Committed: https://crrev.com/996eb9a468745d8f4af72cf7da57876c51886ae2 Cr-Commit-Position: refs/heads/master@{#431914} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/996eb9a468745d8f4af72cf7da57876c51886ae2 Cr-Commit-Position: refs/heads/master@{#431914} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
