Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: src/debug/liveedit.cc

Issue 2475433002: Turn Scope::locals_ into a ThreadedList (Closed)
Patch Set: Fix test again Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/liveedit.cc
diff --git a/src/debug/liveedit.cc b/src/debug/liveedit.cc
index 181453d0a04397b24a08e6f5d9aa22a296a9a7d7..8ef03c74a7bd3fd079f46c8ac1d2452f1762baba 100644
--- a/src/debug/liveedit.cc
+++ b/src/debug/liveedit.cc
@@ -1900,9 +1900,7 @@ Handle<Object> LiveEditFunctionTracker::SerializeFunctionScope(Scope* scope) {
Scope* current_scope = scope;
while (current_scope != NULL) {
HandleScope handle_scope(isolate_);
- ZoneList<Variable*>* locals = current_scope->locals();
- for (int i = 0; i < locals->length(); i++) {
- Variable* var = locals->at(i);
+ for (Variable* var : *current_scope->locals()) {
Yang 2016/11/03 08:13:19 lgtm.
if (!var->IsContextSlot()) continue;
int context_index = var->index() - Context::MIN_CONTEXT_SLOTS;
int location = scope_info_length + context_index * 2;

Powered by Google App Engine
This is Rietveld 408576698