Turn Scope::locals_ into a ThreadedList

src/ast/scopeinfo.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 
 #include "src/ast/context-slot-cache.h"
 #include "src/ast/scopes.h"
 #include "src/ast/variables.h"
 #include "src/bootstrapper.h"
@@ skipping 40 matching lines @@
       }
     }
   }
   return true;
 }
 #endif
 
 Handle<ScopeInfo> ScopeInfo::Create(Isolate* isolate, Zone* zone, Scope* scope,
                                     MaybeHandle<ScopeInfo> outer_scope) {
   // Collect variables.
-  ZoneList<Variable*>* locals = scope->locals();
   int stack_local_count = 0;
   int context_local_count = 0;
   int module_vars_count = 0;
   // Stack allocated block scope variables are allocated in the parent
   // declaration scope, but are recorded in the block scope's scope info. First
   // slot index indicates at which offset a particular scope starts in the
   // parent declaration scope.
   int first_slot_index = 0;
-  for (int i = 0; i < locals->length(); i++) {
-    Variable* var = locals->at(i);
+  for (Variable* var : *scope->locals()) {
     switch (var->location()) {
       case VariableLocation::LOCAL:
         if (stack_local_count == 0) first_slot_index = var->index();
         stack_local_count++;
         break;
       case VariableLocation::CONTEXT:
         context_local_count++;
         break;
       case VariableLocation::MODULE:
         module_vars_count++;
@@ skipping 109 matching lines @@
   // Context locals are added using their index.
   DCHECK_EQ(index, scope_info->StackLocalFirstSlotIndex());
   scope_info->set(index++, Smi::FromInt(first_slot_index));
   DCHECK_EQ(index, scope_info->StackLocalNamesIndex());
 
   int stack_local_base = index;
   int context_local_base = stack_local_base + stack_local_count;
   int context_local_info_base = context_local_base + context_local_count;
   int module_var_entry = scope_info->ModuleVariablesIndex();
 
-  for (int i = 0; i < locals->length(); ++i) {
-    Variable* var = locals->at(i);
+  for (Variable* var : *scope->locals()) {
     switch (var->location()) {
       case VariableLocation::LOCAL: {
         int local_index = var->index() - first_slot_index;
         DCHECK_LE(0, local_index);
         DCHECK_LT(local_index, stack_local_count);
         scope_info->set(stack_local_base + local_index, *var->name());
         break;
       }
       case VariableLocation::CONTEXT: {
         // Due to duplicate parameters, context locals aren't guaranteed to come
@@ skipping 732 matching lines @@
     if (String::cast(entry->local_name())->Equals(*local_name)) {
       return entry;
     }
   }
   UNREACHABLE();
   return Handle<ModuleInfoEntry>();
 }
 
 }  // namespace internal
 }  // namespace v8