Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2475393002: Convert fast/dom/Range/getClientRects.html to web-platform test (Closed)

Created:
4 years, 1 month ago by eae
Modified:
4 years, 1 month ago
Reviewers:
szager1
CC:
chromium-reviews, blink-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert fast/dom/Range/getClientRects.html to web-platform test Rewrite the fast/dom/Range/getClientRects.html layout test to rely on a reference rendering for each test case instead of hardcoded line rects. TBR=szager@chromium.org BUG=464851 TEST=fast/dom/Range/getClientRects.html Committed: https://crrev.com/106fabac57b8b1b05065e1d7b65dcd794acd8440 Cr-Commit-Position: refs/heads/master@{#430162}

Patch Set 1 #

Patch Set 2 : Rebase w/HEAD #

Patch Set 3 : Resore element results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+481 lines, -1082 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Range/getClientRects.html View 1 chunk +481 lines, -410 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/dom/Range/getClientRects-expected.txt View 1 chunk +0 lines, -224 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/dom/Range/getClientRects-expected.txt View 1 chunk +0 lines, -224 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/dom/Range/getClientRects-expected.txt View 1 chunk +0 lines, -224 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
eae
4 years, 1 month ago (2016-11-04 18:19:15 UTC) #1
eae
The tests failures is due to me incorrectly removing the dom/Element/getClientRects-expected.txt file. I'll upload a ...
4 years, 1 month ago (2016-11-04 19:32:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475393002/40001
4 years, 1 month ago (2016-11-05 11:11:49 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-05 11:16:38 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 11:18:44 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/106fabac57b8b1b05065e1d7b65dcd794acd8440
Cr-Commit-Position: refs/heads/master@{#430162}

Powered by Google App Engine
This is Rietveld 408576698