Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2475383002: [layoutng] For min/max-content, take CanUseNewLayout() into account (Closed)

Created:
4 years, 1 month ago by cbiesinger
Modified:
4 years, 1 month ago
Reviewers:
atotic, eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] For min/max-content, take CanUseNewLayout() into account Otherwise we'll crash when we have inlines. R=atotic@chromium.org,eae@chromium.org BUG=635619 Committed: https://crrev.com/3e1ff14ac40160b59482a6a5b7f831fed757804d Cr-Commit-Position: refs/heads/master@{#430045}

Patch Set 1 #

Patch Set 2 : min -> max #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
cbiesinger
4 years, 1 month ago (2016-11-04 17:48:27 UTC) #1
atotic
lgtm
4 years, 1 month ago (2016-11-04 17:55:46 UTC) #6
eae
LGTM
4 years, 1 month ago (2016-11-04 18:27:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475383002/20001
4 years, 1 month ago (2016-11-04 18:30:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 22:50:23 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 22:54:51 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e1ff14ac40160b59482a6a5b7f831fed757804d
Cr-Commit-Position: refs/heads/master@{#430045}

Powered by Google App Engine
This is Rietveld 408576698