Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2475323003: [Payments] Fix credit card scanning billing address bug. (Closed)

Created:
4 years, 1 month ago by sebsg
Modified:
4 years, 1 month ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Fix credit card scanning billing address bug. BUG=662115 Committed: https://crrev.com/7d128a135ff5b12e0c581a1e137b7d852cb96a5d Cr-Commit-Position: refs/heads/master@{#430034}

Patch Set 1 #

Patch Set 2 : Optimized condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sebsg
Hi Rouslan. Fixing this bug fast but I want to refactor this hint/billingAddressAdapter next. Thanks
4 years, 1 month ago (2016-11-04 15:40:27 UTC) #2
please use gerrit instead
lgtm
4 years, 1 month ago (2016-11-04 21:22:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475323003/20001
4 years, 1 month ago (2016-11-04 21:26:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 22:19:07 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 22:22:56 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7d128a135ff5b12e0c581a1e137b7d852cb96a5d
Cr-Commit-Position: refs/heads/master@{#430034}

Powered by Google App Engine
This is Rietveld 408576698