Issue 2475303002: Revert "Handle the case of Stream.take(0) better." This reverts commit 8cead4090cc0b1184a2ad552003a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2475303002: Revert "Handle the case of Stream.take(0) better." This reverts commit 8cead4090cc0b1184a2ad552003a… (Closed)

Created:
4 years, 1 month ago by Bill Hesse

Modified:
4 years, 1 month ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Handle the case of Stream.take(0) better." This reverts commit 8cead4090cc0b1184a2ad552003ac38cae1e2c77. The test co19/LibTest/async/Stream/take_A01_t02 was failing after this commit, on macos and windows, and perhaps everywhere. BUG= TBR=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/3bd04426a88a2e771ca3da7c21a3ed2b83051d05

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -80 lines)			Patch
M	sdk/lib/async/stream.dart	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	sdk/lib/async/stream_pipe.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/co19/co19-co19.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	tests/lib/async/stream_take_test.dart	View	1 chunk	+0 lines, -63 lines	0 comments	Download

Total messages: 2 (1 generated)

Bill Hesse

4 years, 1 month ago (2016-11-04 14:47:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3bd04426a88a2e771ca3da7c21a3ed2b83051d05 (presubmit successful).