third_party/WebKit/Source/modules/remoteplayback/testing/InternalsRemotePlayback.idl - Issue 2475293003: [RemotePlayback] No monitoring on low-end devices

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/remoteplayback/testing/InternalsRemotePlayback.idl

Issue 2475293003: [RemotePlayback] No monitoring on low-end devices (Closed)

Patch Set: Added the internals files Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/remoteplayback/watch-availability-throws-low-end-device.html ('K') | « third_party/WebKit/Source/modules/remoteplayback/testing/InternalsRemotePlayback.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 partial interface Internals {	5 partial interface Internals {

6 boolean rtcCertificateEquals(RTCCertificate a, RTCCertificate b);	6 void setIsLowEndDevice(RemotePlayback remote, boolean isLowEndDevice);
	mlamouri (slow - plz ping) 2016/11/12 20:53:33 I was actually expecting the internals to change t I was actually expecting the internals to change the value from ProcessHeap directly. Though, maybe you could keep this and do what haraken@ suggested in a follow-up? haraken 2016/11/13 05:56:31 Yeah, that's fine. But at least I want to move thi Show quoted text On 2016/11/12 20:53:33, mlamouri (slow) wrote: > I was actually expecting the internals to change the value from ProcessHeap > directly. Though, maybe you could keep this and do what haraken@ suggested in a > follow-up? Yeah, that's fine. But at least I want to move this API from InternalsRemotePlayback.idl to WindowInternals.idl, since the functionality is not a specific thing to RemotePlayback. bashi 2016/11/13 23:45:12 +1. As for place to add the setter, how about Inte Show quoted text On 2016/11/13 05:56:31, haraken wrote: > Yeah, that's fine. But at least I want to move this API from > InternalsRemotePlayback.idl to WindowInternals.idl, since the functionality is > not a specific thing to RemotePlayback. > +1. As for place to add the setter, how about Internals.idl?
7 };	7 };

OLD	NEW