chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java - Issue 2475213002: Update the Google Search geolocation disclosure to make it more obvious.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

Issue 2475213002: Update the Google Search geolocation disclosure to make it more obvious. (Closed)

Patch Set: Feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

index f70b23633db2734d057e299c3621c56e97828ac5..ea53fd1149a2bf706025b86e5429e98fbdcb5266 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java

@@ -14,6 +14,7 @@ import android.view.View;

import org.chromium.base.ContextUtils;

import org.chromium.chrome.R;

+import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.device.DeviceClassManager;

import org.chromium.chrome.browser.preferences.PreferencesLauncher;

import org.chromium.chrome.browser.preferences.SearchEnginePreference;

@@ -61,6 +62,7 @@ public class GeolocationSnackbarController implements SnackbarController {

public static void maybeShowSnackbar(final SnackbarManager snackbarManager, View view,

boolean isIncognito, int delayMs) {

final Context context = view.getContext();

+ if (ChromeFeatureList.isEnabled(ChromeFeatureList.CONSISTENT_OMNIBOX_GEOLOCATION)) return;

if (getGeolocationSnackbarShown(context)) return;

// If in incognito mode, don't show the snackbar now, but maybe show it later.