Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1598)

Side by Side Diff: chrome/browser/ui/tab_helpers.cc

Issue 2475213002: Update the Google Search geolocation disclosure to make it more obvious. (Closed)
Patch Set: Feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tab_helpers.h" 5 #include "chrome/browser/ui/tab_helpers.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 #include "components/password_manager/core/browser/password_manager.h" 58 #include "components/password_manager/core/browser/password_manager.h"
59 #include "components/subresource_filter/content/browser/content_subresource_filt er_driver_factory.h" 59 #include "components/subresource_filter/content/browser/content_subresource_filt er_driver_factory.h"
60 #include "components/tracing/common/tracing_switches.h" 60 #include "components/tracing/common/tracing_switches.h"
61 #include "content/public/browser/web_contents.h" 61 #include "content/public/browser/web_contents.h"
62 62
63 #if BUILDFLAG(ANDROID_JAVA_UI) 63 #if BUILDFLAG(ANDROID_JAVA_UI)
64 #include "chrome/browser/android/banners/app_banner_manager_android.h" 64 #include "chrome/browser/android/banners/app_banner_manager_android.h"
65 #include "chrome/browser/android/data_usage/data_use_tab_helper.h" 65 #include "chrome/browser/android/data_usage/data_use_tab_helper.h"
66 #include "chrome/browser/android/offline_pages/offline_page_tab_helper.h" 66 #include "chrome/browser/android/offline_pages/offline_page_tab_helper.h"
67 #include "chrome/browser/android/offline_pages/recent_tab_helper.h" 67 #include "chrome/browser/android/offline_pages/recent_tab_helper.h"
68 #include "chrome/browser/android/search_geolocation_disclosure_tab_helper.h"
68 #include "chrome/browser/android/voice_search_tab_helper.h" 69 #include "chrome/browser/android/voice_search_tab_helper.h"
69 #include "chrome/browser/android/webapps/single_tab_mode_tab_helper.h" 70 #include "chrome/browser/android/webapps/single_tab_mode_tab_helper.h"
70 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 71 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
71 #include "chrome/browser/ntp_snippets/bookmark_last_visit_updater.h" 72 #include "chrome/browser/ntp_snippets/bookmark_last_visit_updater.h"
72 #include "chrome/browser/ui/android/context_menu_helper.h" 73 #include "chrome/browser/ui/android/context_menu_helper.h"
73 #include "chrome/browser/ui/android/view_android_helper.h" 74 #include "chrome/browser/ui/android/view_android_helper.h"
74 #else 75 #else
75 #include "chrome/browser/banners/app_banner_manager_desktop.h" 76 #include "chrome/browser/banners/app_banner_manager_desktop.h"
76 #include "chrome/browser/plugins/plugin_observer.h" 77 #include "chrome/browser/plugins/plugin_observer.h"
77 #include "chrome/browser/safe_browsing/safe_browsing_tab_observer.h" 78 #include "chrome/browser/safe_browsing/safe_browsing_tab_observer.h"
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 banners::AppBannerManagerAndroid::CreateForWebContents(web_contents); 201 banners::AppBannerManagerAndroid::CreateForWebContents(web_contents);
201 BookmarkLastVisitUpdater::CreateForWebContentsWithBookmarkModel( 202 BookmarkLastVisitUpdater::CreateForWebContentsWithBookmarkModel(
202 web_contents, BookmarkModelFactory::GetForBrowserContext( 203 web_contents, BookmarkModelFactory::GetForBrowserContext(
203 web_contents->GetBrowserContext())); 204 web_contents->GetBrowserContext()));
204 ContextMenuHelper::CreateForWebContents(web_contents); 205 ContextMenuHelper::CreateForWebContents(web_contents);
205 DataUseTabHelper::CreateForWebContents(web_contents); 206 DataUseTabHelper::CreateForWebContents(web_contents);
206 207
207 offline_pages::OfflinePageTabHelper::CreateForWebContents(web_contents); 208 offline_pages::OfflinePageTabHelper::CreateForWebContents(web_contents);
208 offline_pages::RecentTabHelper::CreateForWebContents(web_contents); 209 offline_pages::RecentTabHelper::CreateForWebContents(web_contents);
209 210
211 SearchGeolocationDisclosureTabHelper::CreateForWebContents(web_contents);
210 SingleTabModeTabHelper::CreateForWebContents(web_contents); 212 SingleTabModeTabHelper::CreateForWebContents(web_contents);
211 ViewAndroidHelper::CreateForWebContents(web_contents); 213 ViewAndroidHelper::CreateForWebContents(web_contents);
212 VoiceSearchTabHelper::CreateForWebContents(web_contents); 214 VoiceSearchTabHelper::CreateForWebContents(web_contents);
213 #else 215 #else
214 BookmarkTabHelper::CreateForWebContents(web_contents); 216 BookmarkTabHelper::CreateForWebContents(web_contents);
215 extensions::ChromeExtensionWebContentsObserver::CreateForWebContents( 217 extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
216 web_contents); 218 web_contents);
217 extensions::WebNavigationTabObserver::CreateForWebContents(web_contents); 219 extensions::WebNavigationTabObserver::CreateForWebContents(web_contents);
218 HungPluginTabHelper::CreateForWebContents(web_contents); 220 HungPluginTabHelper::CreateForWebContents(web_contents);
219 JavaScriptDialogTabHelper::CreateForWebContents(web_contents); 221 JavaScriptDialogTabHelper::CreateForWebContents(web_contents);
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 271
270 if (predictors::ResourcePrefetchPredictorFactory::GetForProfile( 272 if (predictors::ResourcePrefetchPredictorFactory::GetForProfile(
271 web_contents->GetBrowserContext())) { 273 web_contents->GetBrowserContext())) {
272 predictors::ResourcePrefetchPredictorTabHelper::CreateForWebContents( 274 predictors::ResourcePrefetchPredictorTabHelper::CreateForWebContents(
273 web_contents); 275 web_contents);
274 } 276 }
275 277
276 if (tracing::NavigationTracingObserver::IsEnabled()) 278 if (tracing::NavigationTracingObserver::IsEnabled())
277 tracing::NavigationTracingObserver::CreateForWebContents(web_contents); 279 tracing::NavigationTracingObserver::CreateForWebContents(web_contents);
278 } 280 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698