Update the Google Search geolocation disclosure to make it more obvious.

chrome/browser/android/search_geolocation_disclosure_infobar_delegate.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_DISCLOSURE_INFOBAR_DELEGATE_H_
+#define CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_DISCLOSURE_INFOBAR_DELEGATE_H_
+
+#include <stddef.h>
+
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
+#include "base/logging.h"
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "base/strings/string16.h"
+#include "build/build_config.h"
+#include "components/infobars/core/infobar_delegate.h"
+
+namespace content {
+class WebContents;
+}
+
+class SearchGeolocationDisclosureInfoBarDelegate
+    : public infobars::InfoBarDelegate {
+ public:
+  ~SearchGeolocationDisclosureInfoBarDelegate() override;
+
+  base::string16 GetMessageText() const;
+
+  static void Create(content::WebContents* web_contents);

[Peter Kasting, 2016/11/08 01:17:51]

Nit: I would tend to prefer this immediately after the destructor, since it's
the first thing callers access and it's kind of serving as a constructor. 
Should have a descriptive comment too (as should GetMessageText(), probably).

[benwells, 2016/11/08 02:53:40]

Done.

+
+ protected:
+  SearchGeolocationDisclosureInfoBarDelegate();

[Peter Kasting, 2016/11/08 01:17:51]

Why is this protected when there are no subclasses?  I think it should be
private.

[benwells, 2016/11/08 02:53:40]

Made private.

+
+ private:
+  // InfoBarDelegate:
+  Type GetInfoBarType() const override;
+  infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
+  int GetIconId() const override;
+  SearchGeolocationDisclosureInfoBarDelegate*
+  AsSearchGeolocationDisclosureInfoBarDelegate() override;
+
+  DISALLOW_COPY_AND_ASSIGN(SearchGeolocationDisclosureInfoBarDelegate);
+};
+
+#endif  // CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_DISCLOSURE_INFOBAR_DELEGATE_H_