[compiler] Remove --ignition-preserve-bytecode flag.

[compiler] Remove --ignition-preserve-bytecode flag.

This removes the deprecated flag in question which has been enabled by
default a while ago. All components can by now deal with activations of
a single function being mixed between Ignition and other compilers. The
maintenance overhead to support a mode that clears bytecode is no longer
warranted.

R=rmcilroy@chromium.org
BUG=v8:4280
Committed: https://crrev.com/012198813420876f932af7132d652db5f0597670
Cr-Commit-Position: refs/heads/master@{#40776}

[Michael Starzinger, 2016-11-04 10:07:12]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 10:07:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-11-04 10:09:40]

Description was changed from

==========
[compiler] Remove --ignition-preserve-bytecode flag.

This removes the deprecated flag in question which has been enabled by
default a while ago. All components can by now deal with activations of
a single function being mixed between Ignition and other compilers. The
maintenance overhead of support a mode that clears bytecode is no longer
warranted.

R=rmcilroy@chromium.org
BUG=v8:4280
==========

to

==========
[compiler] Remove --ignition-preserve-bytecode flag.

This removes the deprecated flag in question which has been enabled by
default a while ago. All components can by now deal with activations of
a single function being mixed between Ignition and other compilers. The
maintenance overhead to support a mode that clears bytecode is no longer
warranted.

R=rmcilroy@chromium.org
BUG=v8:4280
==========

[commit-bot: I haz the power, 2016-11-04 10:34:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 10:34:02]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-11-04 14:23:34]

LGTM thanks.

https://codereview.chromium.org/2475203003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2475203003/diff/1/src/compiler.cc#newcode810
src/compiler.cc:810: // TurboFan in this case.
Do we want to do anything about this? I don't think we should hit this path any
longer because we will go directly to optimizing the code for generators / async
functions, so we can probably just remove this check too

[Michael Starzinger, 2016-11-04 14:27:53]

https://codereview.chromium.org/2475203003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2475203003/diff/1/src/compiler.cc#newcode810
src/compiler.cc:810: // TurboFan in this case.
On 2016/11/04 14:23:34, rmcilroy (OOO - slow) wrote:
> Do we want to do anything about this? I don't think we should hit this path
any
> longer because we will go directly to optimizing the code for generators /
async
> functions, so we can probably just remove this check too

Acknowledged. At first glance I agree with you. The same should apply to
Compiler::EnsureDeoptimizationSupport below as well. I would however like to do
this in a separate CL and think it through more thoroughly. WDYT? It's already
marked with a TODO, so I think the action item won't get lost.

[rmcilroy, 2016-11-04 15:06:28]

On 2016/11/04 14:27:53, Michael Starzinger wrote:
> https://codereview.chromium.org/2475203003/diff/1/src/compiler.cc
> File src/compiler.cc (right):
> 
> https://codereview.chromium.org/2475203003/diff/1/src/compiler.cc#newcode810
> src/compiler.cc:810: // TurboFan in this case.
> On 2016/11/04 14:23:34, rmcilroy (OOO - slow) wrote:
> > Do we want to do anything about this? I don't think we should hit this path
> any
> > longer because we will go directly to optimizing the code for generators /
> async
> > functions, so we can probably just remove this check too
> 
> Acknowledged. At first glance I agree with you. The same should apply to
> Compiler::EnsureDeoptimizationSupport below as well. I would however like to
do
> this in a separate CL and think it through more thoroughly. WDYT? It's already
> marked with a TODO, so I think the action item won't get lost.

Yup a seperate CL sounds good. Thanks.

[Michael Starzinger, 2016-11-04 16:06:34]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-11-04 16:06:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 16:08:42]

Description was changed from

==========
[compiler] Remove --ignition-preserve-bytecode flag.

This removes the deprecated flag in question which has been enabled by
default a while ago. All components can by now deal with activations of
a single function being mixed between Ignition and other compilers. The
maintenance overhead to support a mode that clears bytecode is no longer
warranted.

R=rmcilroy@chromium.org
BUG=v8:4280
==========

to

==========
[compiler] Remove --ignition-preserve-bytecode flag.

This removes the deprecated flag in question which has been enabled by
default a while ago. All components can by now deal with activations of
a single function being mixed between Ignition and other compilers. The
maintenance overhead to support a mode that clears bytecode is no longer
warranted.

R=rmcilroy@chromium.org
BUG=v8:4280
==========

[commit-bot: I haz the power, 2016-11-04 16:08:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:23:23]

Description was changed from

==========
[compiler] Remove --ignition-preserve-bytecode flag.

This removes the deprecated flag in question which has been enabled by
default a while ago. All components can by now deal with activations of
a single function being mixed between Ignition and other compilers. The
maintenance overhead to support a mode that clears bytecode is no longer
warranted.

R=rmcilroy@chromium.org
BUG=v8:4280
==========

to

==========
[compiler] Remove --ignition-preserve-bytecode flag.

This removes the deprecated flag in question which has been enabled by
default a while ago. All components can by now deal with activations of
a single function being mixed between Ignition and other compilers. The
maintenance overhead to support a mode that clears bytecode is no longer
warranted.

R=rmcilroy@chromium.org
BUG=v8:4280

Committed: https://crrev.com/012198813420876f932af7132d652db5f0597670
Cr-Commit-Position: refs/heads/master@{#40776}
==========

[commit-bot: I haz the power, 2016-11-17 22:23:24]

Patchset 1 (id:??) landed as
https://crrev.com/012198813420876f932af7132d652db5f0597670
Cr-Commit-Position: refs/heads/master@{#40776}