Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 24752002: Cleanup <static_cast>: Switch to toFoo for Accessibility Objects. (Closed)

Created:
7 years, 2 months ago by r.kasibhatla
Modified:
7 years, 2 months ago
CC:
blink-reviews, dmazzoni, jeez, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Cleanup <static_cast>: Switch to toFoo for Accessibility Objects. To enforce more strictly the avoidance of static_cast on render objects, existing usage of static_cast needs to be corrected first. R=tkent BUG=None TEST=None; no behavior changes; Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -28 lines) Patch
M Source/core/accessibility/AXObjectCache.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/accessibility/AccessibilityARIAGrid.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AccessibilityARIAGridCell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityImageMapLink.h View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/accessibility/AccessibilityListBox.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/accessibility/AccessibilityListBoxOption.h View 2 chunks +16 lines, -0 lines 0 comments Download
M Source/core/accessibility/AccessibilityMenuList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityMenuListOption.h View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/accessibility/AccessibilityMenuListPopup.h View 2 chunks +15 lines, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityMenuListPopup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityObject.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/accessibility/AccessibilityRenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityScrollView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AccessibilityScrollbar.h View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/accessibility/AccessibilityTable.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/accessibility/AccessibilityTableCell.h View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/accessibility/AccessibilityTableColumn.h View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/accessibility/AccessibilityTableRow.h View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/accessibility/AccessibilityTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/Scrollbar.h View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/web/WebAXObject.cpp View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
r.kasibhatla
PTAL.
7 years, 2 months ago (2013-09-26 13:22:00 UTC) #1
dmazzoni
lgtm
7 years, 2 months ago (2013-09-26 15:04:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/24752002/1
7 years, 2 months ago (2013-09-26 21:01:26 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=7560
7 years, 2 months ago (2013-09-26 21:12:15 UTC) #4
tkent
Source/web lgtm.
7 years, 2 months ago (2013-09-26 21:19:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/24752002/1
7 years, 2 months ago (2013-09-26 21:19:52 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 22:26:00 UTC) #7
Message was sent while issue was closed.
Change committed as 158399

Powered by Google App Engine
This is Rietveld 408576698