Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2475163003: aw: Deflake testUnknownTypeUnrecognizedNode (Closed)

Created:
4 years, 1 month ago by boliu
Modified:
4 years, 1 month ago
Reviewers:
paulmiller
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Deflake testUnknownTypeUnrecognizedNode The flake is probably due to the test server re-using the same url for different test pages. Changed so that each test page gets a new url. Then found out the test is still flaky because apparently onPageFinished doesn't mean blink has committed the new page so it's hit-testable. So also wait for the page commit signal. This replaces polling for title in the test. BUG=662078 Committed: https://crrev.com/e39ff7bb09b58c32541dcd08bba54dc928617f22 Cr-Commit-Position: refs/heads/master@{#430317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java View 6 chunks +13 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
boliu
ptal
4 years, 1 month ago (2016-11-04 18:08:03 UTC) #6
paulmiller
On 2016/11/04 18:08:03, boliu wrote: > ptal lgtm
4 years, 1 month ago (2016-11-07 17:47:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475163003/1
4 years, 1 month ago (2016-11-07 17:51:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 18:12:41 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 18:29:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e39ff7bb09b58c32541dcd08bba54dc928617f22
Cr-Commit-Position: refs/heads/master@{#430317}

Powered by Google App Engine
This is Rietveld 408576698