Split out AVDA cleanups from SetSurface() change.

Split out AVDA cleanups from SetSurface() change.

This shifts various pieces of AVDA code around to make it easier
to implement MediaCodec.setSurface(). There are no functional
changes within this CL, just cleanups and relocations. Namely:

- OnFrameAvailableHandler moves into AVDASharedState since we'll
  change AVDASharedState instances in the future when the surface
  changes.
- The map of codec images is now owned by AVDAPictureBufferManager;
  consequently, self-registration in the AVDACodecImage is removed.
- Elided some methods to remove duplicate internal work.
- AVDACodecImages are now held by refptr in AVDAPictureBufferManager
  since we'll need to call code which would otherwise drop their
  last ref in the future.

BUG=662251
TEST=playback still works.

Committed: https://crrev.com/d65783431437f61ed9962c4e6968fce6103ca2e1
Cr-Commit-Position: refs/heads/master@{#430064}

[DaleCurtis, 2016-11-04 00:52:35]

Patchset #1 (id:1) has been deleted

[DaleCurtis, 2016-11-04 00:52:55]

dalecurtis@chromium.org changed reviewers:
+ liberato@chromium.org, watk@chromium.org

[DaleCurtis, 2016-11-04 00:52:55]

This pulls out the relocation/cleanup only pieces from the setSurface CL for
easier reviewing.

[liberato (no reviews please), 2016-11-04 18:02:14]

lgtm.

https://codereview.chromium.org/2475133002/diff/20001/media/gpu/avda_shared_s...
File media/gpu/avda_shared_state.cc (right):

https://codereview.chromium.org/2475133002/diff/20001/media/gpu/avda_shared_s...
media/gpu/avda_shared_state.cc:80: on_frame_available_handler_->ClearListener();
might want to if(on_frame_...) { clearlistener } before the early return at line
77, just in case this gets out of sync somehow with
|surface_texture_service_id_|.

https://codereview.chromium.org/2475133002/diff/20001/media/gpu/avda_shared_s...
File media/gpu/avda_shared_state.h (right):

https://codereview.chromium.org/2475133002/diff/20001/media/gpu/avda_shared_s...
media/gpu/avda_shared_state.h:77: void clear_release_time() { release_time_ =
base::TimeTicks(); }
ClearReleaseTime()?

[DaleCurtis, 2016-11-04 19:42:42]

https://codereview.chromium.org/2475133002/diff/20001/media/gpu/avda_shared_s...
File media/gpu/avda_shared_state.cc (right):

https://codereview.chromium.org/2475133002/diff/20001/media/gpu/avda_shared_s...
media/gpu/avda_shared_state.cc:80: on_frame_available_handler_->ClearListener();
On 2016/11/04 at 18:02:14, liberato wrote:
> might want to if(on_frame_...) { clearlistener } before the early return at
line 77, just in case this gets out of sync somehow with
|surface_texture_service_id_|.

Should be impossible since SetSurfaceTexture can only be called once. Generally
we want to avoid introducing checks for somehow :)

https://codereview.chromium.org/2475133002/diff/20001/media/gpu/avda_shared_s...
File media/gpu/avda_shared_state.h (right):

https://codereview.chromium.org/2475133002/diff/20001/media/gpu/avda_shared_s...
media/gpu/avda_shared_state.h:77: void clear_release_time() { release_time_ =
base::TimeTicks(); }
On 2016/11/04 at 18:02:14, liberato wrote:
> ClearReleaseTime()?

Inline methods must always be hacker_style().

[watk, 2016-11-04 21:06:17]

lgtm

[DaleCurtis, 2016-11-04 21:18:56]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-11-04 21:18:56]

Per watk@, I ran the VDA unittests and it passes \o/ Thanks for review!

[commit-bot: I haz the power, 2016-11-04 21:19:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 23:24:09]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-11-04 23:27:10]

Description was changed from

==========
Split out AVDA cleanups from SetSurface() change.

This shifts various pieces of AVDA code around to make it easier
to implement MediaCodec.setSurface(). There are no functional
changes within this CL, just cleanups and relocations. Namely:

- OnFrameAvailableHandler moves into AVDASharedState since we'll
  change AVDASharedState instances in the future when the surface
  changes.
- The map of codec images is now owned by AVDAPictureBufferManager;
  consequently, self-registration in the AVDACodecImage is removed.
- Elided some methods to remove duplicate internal work.
- AVDACodecImages are now held by refptr in AVDAPictureBufferManager
  since we'll need to call code which would otherwise drop their
  last ref in the future.

BUG=662251
TEST=playback still works.
==========

to

==========
Split out AVDA cleanups from SetSurface() change.

This shifts various pieces of AVDA code around to make it easier
to implement MediaCodec.setSurface(). There are no functional
changes within this CL, just cleanups and relocations. Namely:

- OnFrameAvailableHandler moves into AVDASharedState since we'll
  change AVDASharedState instances in the future when the surface
  changes.
- The map of codec images is now owned by AVDAPictureBufferManager;
  consequently, self-registration in the AVDACodecImage is removed.
- Elided some methods to remove duplicate internal work.
- AVDACodecImages are now held by refptr in AVDAPictureBufferManager
  since we'll need to call code which would otherwise drop their
  last ref in the future.

BUG=662251
TEST=playback still works.

Committed: https://crrev.com/d65783431437f61ed9962c4e6968fce6103ca2e1
Cr-Commit-Position: refs/heads/master@{#430064}
==========

[commit-bot: I haz the power, 2016-11-04 23:27:11]

Patchset 1 (id:??) landed as
https://crrev.com/d65783431437f61ed9962c4e6968fce6103ca2e1
Cr-Commit-Position: refs/heads/master@{#430064}