Refactor ArcSupportHost and ArcAuthService part 1.

Refactor ArcSupportHost and ArcAuthService part 1.

This CL contains three simple refactoring:
- Move UIPage from ArcAuthService to ArcSupportHost.
- Move logic in ArcSupportHost::OnMessage to ArcAuthService.
  For this purpose, Observer is introduced.
- Move ArcOptInPreferenceHandler from ArcSupportHost to
  ArcAuthService.

Moved code will be extracted again, when ArcSessionManager
is introduced.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran bots.

Committed: https://crrev.com/e929bc07aa6ce653f7df89f425f01f307839e89c
Cr-Commit-Position: refs/heads/master@{#430497}

[hidehiko, 2016-11-04 03:22:53]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[hidehiko, 2016-11-04 03:23:27]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2016-11-04 03:23:27]

PTAL: Luis. FYI: Yury.

[commit-bot: I haz the power, 2016-11-04 03:23:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 05:21:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 05:21:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hidehiko, 2016-11-04 17:51:18]

On 2016/11/04 03:23:27, hidehiko wrote:
> PTAL: Luis. FYI: Yury.

Oops, test error is real my mistake. Fixing...

[Luis Héctor Chávez, 2016-11-04 17:55:15]

lgtm with nits

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:798: ui_page_ !=
ArcSupportHost::UIPage::ERROR_WITH_FEEDBACK)
nit: un-elide braces (multi-line conditions cannot elide braces).

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:802: if (ui_page_ ==
ArcSupportHost::UIPage::ERROR_WITH_FEEDBACK) {
nit: elide braces

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:989: if (support_host_)
nit:

if (!support_host_)
  return;

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_support_host.h (right):

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_support_host.h:61: void set_observer(Observer*
observer) { observer_ = observer; }
If the plan is to support multiple observers, I'd rather have the correct
interface right now: AddObserver(...). RemoveObserver(...) can wait until it's
owned by the right class.

Also, DCHECK(!observer_);

[hidehiko, 2016-11-04 22:18:20]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 22:19:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hidehiko, 2016-11-04 22:19:51]

Thank you for review!

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:798: ui_page_ !=
ArcSupportHost::UIPage::ERROR_WITH_FEEDBACK)
On 2016/11/04 17:55:15, Luis Héctor Chávez wrote:
> nit: un-elide braces (multi-line conditions cannot elide braces).

Done.

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:802: if (ui_page_ ==
ArcSupportHost::UIPage::ERROR_WITH_FEEDBACK) {
On 2016/11/04 17:55:15, Luis Héctor Chávez wrote:
> nit: elide braces

Done.

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:989: if (support_host_)
On 2016/11/04 17:55:15, Luis Héctor Chávez wrote:
> nit:
> 
> if (!support_host_)
>   return;

Done.

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_support_host.h (right):

https://codereview.chromium.org/2475073003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_support_host.h:61: void set_observer(Observer*
observer) { observer_ = observer; }
On 2016/11/04 17:55:15, Luis Héctor Chávez wrote:
> If the plan is to support multiple observers, I'd rather have the correct
> interface right now: AddObserver(...). RemoveObserver(...) can wait until it's
> owned by the right class.
> 
> Also, DCHECK(!observer_);

Done.

[Luis Héctor Chávez, 2016-11-04 22:24:03]

lgtm++

[commit-bot: I haz the power, 2016-11-04 22:56:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:56:26]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2016-11-08 02:40:51]

Description was changed from

==========
Fix header dependency between ArcSupportHost and ArcAuthService.

This CL contains three simple refactoring:
- Move UIPage from ArcAuthService to ArcSupportHost.
- Move logic in ArcSupportHost::OnMessage to ArcAuthService.
  For this purpose, Observer is introduced.
- Move ArcOptInPreferenceHandler from ArcSupportHost to
  ArcAuthService.

Moved code will be extracted again, when ArcSessionManager
is introduced.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran bots.
==========

to

==========
Refactor ArcSupportHost and ArcAuthService part 1.

This CL contains three simple refactoring:
- Move UIPage from ArcAuthService to ArcSupportHost.
- Move logic in ArcSupportHost::OnMessage to ArcAuthService.
  For this purpose, Observer is introduced.
- Move ArcOptInPreferenceHandler from ArcSupportHost to
  ArcAuthService.

Moved code will be extracted again, when ArcSessionManager
is introduced.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran bots.
==========

[hidehiko, 2016-11-08 02:41:14]

Re-titled the CL based on offline chat with Luis. Submitting.

[hidehiko, 2016-11-08 02:41:18]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2016-11-08 02:41:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2475073003/#ps70001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-08 02:41:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 03:13:55]

Description was changed from

==========
Refactor ArcSupportHost and ArcAuthService part 1.

This CL contains three simple refactoring:
- Move UIPage from ArcAuthService to ArcSupportHost.
- Move logic in ArcSupportHost::OnMessage to ArcAuthService.
  For this purpose, Observer is introduced.
- Move ArcOptInPreferenceHandler from ArcSupportHost to
  ArcAuthService.

Moved code will be extracted again, when ArcSessionManager
is introduced.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran bots.
==========

to

==========
Refactor ArcSupportHost and ArcAuthService part 1.

This CL contains three simple refactoring:
- Move UIPage from ArcAuthService to ArcSupportHost.
- Move logic in ArcSupportHost::OnMessage to ArcAuthService.
  For this purpose, Observer is introduced.
- Move ArcOptInPreferenceHandler from ArcSupportHost to
  ArcAuthService.

Moved code will be extracted again, when ArcSessionManager
is introduced.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran bots.
==========

[commit-bot: I haz the power, 2016-11-08 03:13:56]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-11-08 03:27:43]

Description was changed from

==========
Refactor ArcSupportHost and ArcAuthService part 1.

This CL contains three simple refactoring:
- Move UIPage from ArcAuthService to ArcSupportHost.
- Move logic in ArcSupportHost::OnMessage to ArcAuthService.
  For this purpose, Observer is introduced.
- Move ArcOptInPreferenceHandler from ArcSupportHost to
  ArcAuthService.

Moved code will be extracted again, when ArcSessionManager
is introduced.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran bots.
==========

to

==========
Refactor ArcSupportHost and ArcAuthService part 1.

This CL contains three simple refactoring:
- Move UIPage from ArcAuthService to ArcSupportHost.
- Move logic in ArcSupportHost::OnMessage to ArcAuthService.
  For this purpose, Observer is introduced.
- Move ArcOptInPreferenceHandler from ArcSupportHost to
  ArcAuthService.

Moved code will be extracted again, when ArcSessionManager
is introduced.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran bots.

Committed: https://crrev.com/e929bc07aa6ce653f7df89f425f01f307839e89c
Cr-Commit-Position: refs/heads/master@{#430497}
==========

[commit-bot: I haz the power, 2016-11-08 03:27:44]

Patchset 5 (id:??) landed as
https://crrev.com/e929bc07aa6ce653f7df89f425f01f307839e89c
Cr-Commit-Position: refs/heads/master@{#430497}