Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2475063002: Set explicit class instead of package for reparenting (Closed)

Created:
4 years, 1 month ago by Yusuf
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set explicit class instead of package for reparenting This avoids the possibility of activity resolution failing on certain urls (images, other non http, https protocols) and causing a crash. We send the url directly to Launcher activity which can disambiguate everything Chrome handles properly. BUG=639206 Committed: https://crrev.com/de40269e7ebc26a8a2fe9f8cfde4062b0a4bf633 Cr-Commit-Position: refs/heads/master@{#429693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Yusuf
4 years, 1 month ago (2016-11-03 20:07:43 UTC) #3
gone
lgtm
4 years, 1 month ago (2016-11-03 20:22:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475063002/1
4 years, 1 month ago (2016-11-03 20:50:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 20:56:49 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 21:00:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de40269e7ebc26a8a2fe9f8cfde4062b0a4bf633
Cr-Commit-Position: refs/heads/master@{#429693}

Powered by Google App Engine
This is Rietveld 408576698