Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: components/sync/engine_impl/cycle/nudge_tracker.cc

Issue 2475043002: [Sync] Sync client should to exponential backoff when receive partial failure (Closed)
Patch Set: code review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/engine_impl/cycle/nudge_tracker.cc
diff --git a/components/sync/engine_impl/cycle/nudge_tracker.cc b/components/sync/engine_impl/cycle/nudge_tracker.cc
index cef95f2379a827f22735c7b445a76e35c802db94..9a4c3014b6359c093951363e73966d5b774ff0c3 100644
--- a/components/sync/engine_impl/cycle/nudge_tracker.cc
+++ b/components/sync/engine_impl/cycle/nudge_tracker.cc
@@ -189,10 +189,18 @@ void NudgeTracker::SetTypesThrottledUntil(ModelTypeSet types,
}
}
-void NudgeTracker::UpdateTypeThrottlingState(base::TimeTicks now) {
+void NudgeTracker::SetTypeBackedOff(ModelType type,
+ base::TimeDelta length,
+ base::TimeTicks now) {
+ TypeTrackerMap::const_iterator tracker_it = type_trackers_.find(type);
+ DCHECK(tracker_it != type_trackers_.end());
+ tracker_it->second->BackoffType(length, now);
+}
+
+void NudgeTracker::UpdateTypeThrottlingAndBackoffState() {
for (TypeTrackerMap::const_iterator it = type_trackers_.begin();
it != type_trackers_.end(); ++it) {
- it->second->UpdateThrottleState(now);
+ it->second->UpdateThrottleOrBackoffState();
}
}
@@ -206,27 +214,53 @@ bool NudgeTracker::IsAnyTypeThrottled() const {
return false;
}
+bool NudgeTracker::IsAnyTypeBackedOff() const {
+ for (TypeTrackerMap::const_iterator it = type_trackers_.begin();
+ it != type_trackers_.end(); ++it) {
+ if (it->second->IsBackedOff()) {
+ return true;
+ }
+ }
+ return false;
+}
+
bool NudgeTracker::IsTypeThrottled(ModelType type) const {
DCHECK(type_trackers_.find(type) != type_trackers_.end());
return type_trackers_.find(type)->second->IsThrottled();
}
-base::TimeDelta NudgeTracker::GetTimeUntilNextUnthrottle(
- base::TimeTicks now) const {
- DCHECK(IsAnyTypeThrottled()) << "This function requires a pending unthrottle";
+bool NudgeTracker::IsTypeBackedOff(ModelType type) const {
+ DCHECK(type_trackers_.find(type) != type_trackers_.end());
+ return type_trackers_.find(type)->second->IsBackedOff();
+}
+
+base::TimeDelta NudgeTracker::GetTimeUntilNextUnblock() const {
+ DCHECK(IsAnyTypeThrottled() || IsAnyTypeBackedOff())
+ << "This function requires a pending unthrottle or unbackoff";
- // Return min of GetTimeUntilUnthrottle() values for all IsThrottled() types.
- base::TimeDelta time_until_next_unthrottle = base::TimeDelta::Max();
+ // Return min of GetTimeUntilUnblock() values for all IsThrottled() and
+ // IsBackedOff() types.
+ base::TimeDelta time_until_next_unblock = base::TimeDelta::Max();
for (TypeTrackerMap::const_iterator it = type_trackers_.begin();
it != type_trackers_.end(); ++it) {
- if (it->second->IsThrottled()) {
- time_until_next_unthrottle = std::min(
- time_until_next_unthrottle, it->second->GetTimeUntilUnthrottle(now));
+ if (it->second->IsThrottled() || it->second->IsBackedOff()) {
+ time_until_next_unblock =
+ std::min(time_until_next_unblock, it->second->GetTimeUntilUnblock());
}
}
- DCHECK(!time_until_next_unthrottle.is_max());
+ DCHECK(!time_until_next_unblock.is_max());
+
+ return time_until_next_unblock;
+}
+
+base::TimeDelta NudgeTracker::GetTypeLastBackoffInterval(ModelType type) const {
+ TypeTrackerMap::const_iterator tracker_it = type_trackers_.find(type);
+ if (tracker_it != type_trackers_.end()) {
+ NOTREACHED();
+ return base::TimeDelta::FromSeconds(0);
+ }
- return time_until_next_unthrottle;
+ return tracker_it->second->GetLastBackoffInterval();
}
ModelTypeSet NudgeTracker::GetThrottledTypes() const {
@@ -240,6 +274,17 @@ ModelTypeSet NudgeTracker::GetThrottledTypes() const {
return result;
}
+ModelTypeSet NudgeTracker::GetBackedOffTypes() const {
+ ModelTypeSet result;
+ for (TypeTrackerMap::const_iterator it = type_trackers_.begin();
+ it != type_trackers_.end(); ++it) {
+ if (it->second->IsBackedOff()) {
+ result.Put(it->first);
+ }
+ }
+ return result;
+}
+
ModelTypeSet NudgeTracker::GetNudgedTypes() const {
ModelTypeSet result;
for (TypeTrackerMap::const_iterator it = type_trackers_.begin();

Powered by Google App Engine
This is Rietveld 408576698